Paths

Table of Contentst

Differential D3897

[native] [chore] [ENG-530] remove arrows from inline sidebar
AbandonedPublic
Actions

Authored by • benschac on May 3 2022, 7:27 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 15, 6:10 AM

	Unknown Object (File)
	Mon, Oct 28, 3:04 AM

	Unknown Object (File)
	Mon, Oct 28, 3:04 AM

	Unknown Object (File)
	Mon, Oct 28, 2:00 AM

	Unknown Object (File)
	Mon, Oct 28, 1:57 AM

	Unknown Object (File)
	Oct 6 2024, 9:01 AM

	Unknown Object (File)
	Sep 28 2024, 11:57 AM

	Unknown Object (File)
	Sep 9 2024, 1:00 PM

Subscribers

Details

Reviewers

ashoat
• jacek
tomek
atul

Summary

remove arrows from native chat screen, per the design. Follow up diff will implement design

image.png (1×732 px, 891 KB)

https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=344%3A491
https://linear.app/comm/issue/ENG-530/inline-sidebar-re-style

Test Plan

Open simulator, go to a chat with sidebars, the arrows should be gone.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.May 3 2022, 7:27 AM

Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMay 3 2022, 7:27 AM

• benschac edited the summary of this revision. (Show Details)May 3 2022, 7:28 AM

• benschac edited the summary of this revision. (Show Details)

• benschac added a parent revision: D3894: [lib] [refactor] [ENG-530] remove list of users string in reply.

Harbormaster completed remote builds in B8736: Diff 12170.May 3 2022, 7:32 AM

• benschac requested review of this revision.May 3 2022, 7:32 AM

ashoat accepted this revision.May 3 2022, 9:36 AM

This revision is now accepted and ready to land.May 3 2022, 9:36 AM

• benschac added a child revision: D3915: [web,native,lib] [refactor] [ENG-530] rename hook to useInlineEngagement from useInlineText.May 4 2022, 9:01 AM

remove unused css classes

Harbormaster completed remote builds in B8823: Diff 12292.May 5 2022, 9:18 AM

(Copied from D3893)

@jacek I think we can abandon these changes since you've started a separate stack to deal with InlineSidebar. Let me know if I'm mistaken and I can re-open this if it tracks some unique work.

atul abandoned this revision.Aug 15 2022, 9:49 AM

atul foisted this revision upon • benschac.

atul edited reviewers, added: atul; removed: • benschac.

Revision Contents
Changeset List

Path

Size

native/

chat/

inline-sidebar.react.js

32 lines

Diff 12292

native/chat/inline-sidebar.react.js

Loading...