[web] [chore] [ENG-530] remove old styles from inline sidebar component
AbandonedPublic
Actions

Authored by • benschac on May 2 2022, 2:41 PM.

Details

Reviewers

ashoat
atul

Summary

remove all old styles and icons since the new design is pretty different from what we have. This diff shouldn't be landed on it's own. More just clean up for updating the component

Test Plan

N/A additionially, there's literally nothing to see here. The text is black by default so you're not going to see anything on the screen.

Diff Detail

Repository

rCOMM Comm

Branch

inline-sidebar-web-and-native-ENG-530

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.May 2 2022, 2:41 PM

Herald added subscribers: • abosh, • karol, • adrian, tomek. · View Herald TranscriptMay 2 2022, 2:41 PM

• benschac added inline comments.May 2 2022, 2:44 PM

web/chat/inline-sidebar.react.js
62 ↗	(On Diff #12159)	There's no use of the `inlineSidebarHeight` grepped the codebase and nothing is showing up.

update export a bit

Harbormaster completed remote builds in B8728: Diff 12159.May 2 2022, 2:45 PM

Harbormaster completed remote builds in B8729: Diff 12160.May 2 2022, 2:51 PM

• benschac requested review of this revision.May 2 2022, 2:51 PM

• benschac added a child revision: D3894: [lib] [refactor] [ENG-530] remove list of users string in reply.May 3 2022, 3:50 AM

ashoat accepted this revision.May 3 2022, 9:30 AM

This revision is now accepted and ready to land.May 3 2022, 9:30 AM

@jacek I think we can abandon these changes since you've started a separate stack to deal with InlineSidebar. Let me know if I'm mistaken and I can re-open this if it tracks some unique work.

atul abandoned this revision.Aug 15 2022, 9:40 AM

atul foisted this revision upon • benschac.

atul edited reviewers, added: atul; removed: • benschac.

atul mentioned this in D3895: [web] [chore] [ENG-530] style inline sidebar.

atul mentioned this in D3897: [native] [chore] [ENG-530] remove arrows from inline sidebar.Aug 15 2022, 9:49 AM

atul mentioned this in D3971: [refactor] [native] [ENG-530] Remove positioning prop from InlineSidebar component.

atul mentioned this in D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.

atul mentioned this in D4005: [native] [refactor] [ENG-530] rename inline-sidebar to inline-engagement.Aug 15 2022, 9:53 AM

atul mentioned this in D4115: [native] [feat] [ENG-530] add icon to inline engagement.Aug 15 2022, 10:04 AM