Paths

Table of Contentst

[web] [chore] [ENG-530] style inline sidebar
AbandonedPublic
Actions

Authored by • benschac on May 3 2022, 4:49 AM.

Details

Reviewers

ashoat
• jacek
tomek
atul

Summary

core styling to match figma.

https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77791

https://linear.app/comm/issue/ENG-530/inline-sidebar-re-style

right little content:

right lots of content same message grouping:

right image:

left image:

left little content:

left lots of content:

unread bold:

This diff needs to be landed with the entire stack.

Test Plan

Inspect the inline chat bar with figma. Make sure the design matches the code.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.May 3 2022, 4:49 AM

Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMay 3 2022, 4:49 AM

• benschac edited the summary of this revision. (Show Details)May 3 2022, 4:50 AM

• benschac added a parent revision: D3894: [lib] [refactor] [ENG-530] remove list of users string in reply.

• benschac edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B8731: Diff 12162.May 3 2022, 4:54 AM

• benschac requested review of this revision.May 3 2022, 4:54 AM

• benschac added a child revision: D3896: [refactor] [web] [ENG-530] rename prop from positioning to position.May 3 2022, 5:07 AM

add more styles

Harbormaster completed remote builds in B8734: Diff 12165.May 3 2022, 7:00 AM

• benschac edited the summary of this revision. (Show Details)May 3 2022, 7:00 AM

• benschac edited the summary of this revision. (Show Details)

I removed the bolding functionality and I didn't re-add it yet. Going to put this back as plan changes for now.

In a later diff it would probably be good to rename InlineSidebar to InlineFeedback, InlineReactions, InlineResponses, or InlineEngagement or something

In D3895#108996, @ashoat wrote:

In a later diff it would probably be good to rename InlineSidebar to InlineFeedback, InlineReactions, InlineResponses, or InlineEngagement or something

Yeah, that makes sense.

re add bold styling to inline sidebar

rename cls

• benschac edited the summary of this revision. (Show Details)May 4 2022, 8:48 AM

Harbormaster failed remote builds in B8777: Diff 12224!May 4 2022, 8:51 AM

Harbormaster completed remote builds in B8778: Diff 12225.May 4 2022, 8:55 AM

• benschac mentioned this in D3915: [web,native,lib] [refactor] [ENG-530] rename hook to useInlineEngagement from useInlineText.May 4 2022, 9:00 AM

In D3895#108996, @ashoat wrote:

In a later diff it would probably be good to rename InlineSidebar to InlineFeedback, InlineReactions, InlineResponses, or InlineEngagement or something

https://phabricator.ashoat.com/D3915

Not 100% sure what's going on here, but it looks right

This revision is now accepted and ready to land.May 4 2022, 11:10 AM

• benschac mentioned this in D4005: [native] [refactor] [ENG-530] rename inline-sidebar to inline-engagement.May 11 2022, 8:45 AM

(Copied from D3893)

@jacek I think we can abandon these changes since you've started a separate stack to deal with InlineSidebar. Let me know if I'm mistaken and I can re-open this if it tracks some unique work.

atul abandoned this revision.Aug 15 2022, 9:41 AM

atul foisted this revision upon • benschac.

atul edited reviewers, added: atul; removed: • benschac.