Page MenuHomePhabricator
Differential D3894

[lib] [refactor] [ENG-530] remove list of users string in reply
AcceptedPublic
Actions

Authored by • benschac on May 3 2022, 3:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 6:46 AM
Unknown Object (File)
Tue, Apr 8, 5:37 AM
Unknown Object (File)
Mon, Apr 7, 6:17 AM
Unknown Object (File)
Sun, Apr 6, 5:41 PM
Unknown Object (File)
Mon, Mar 31, 5:23 PM
Unknown Object (File)
Mar 17 2025, 7:16 AM
Unknown Object (File)
Mar 17 2025, 7:15 AM
Unknown Object (File)
Mar 17 2025, 7:03 AM
View All Files
Subscribers
• abosh
• adrian
• jacek
• karol
tomek

Details

Reviewers
ashoat
atul
Summary

The design no longer calls for a list of users who have replied to the sidebar figma: https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77791 in reply

https://linear.app/comm/issue/ENG-530/inline-sidebar-re-style

Test Plan

No test plan, other than confirming the design doesn't have the functionality I'm removing. I did speak with ashoat about the hover functionality of the reply bubble where users' names would show. He was a bit on the fence about it. Either way, we have this commit in git history and can always grab it and re-introduce if needed.

Additionally, this shouldn't be landed until the stack is ready.

Diff Detail

Repository
rCOMM Comm
Branch
inline-sidebar-web-and-native-ENG-530
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
hooks/
18 lines
utils/
15 lines
native/
chat/
7 lines
web/
chat/
7 lines

Diff 12161

View Options

lib/hooks/inline-sidebar-text.react.js

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines if (messageActionButtons) {
); );
} }
const viewerActionLinks = isViewer ? messageActionLinks : null; const viewerActionLinks = isViewer ? messageActionLinks : null;
const nonViewerActionLinks = !isViewer ? messageActionLinks : null; const nonViewerActionLinks = !isViewer ? messageActionLinks : null;
let inlineSidebar = null; let inlineSidebar = null;
if (item.threadCreatedFromMessage) { if (item.threadCreatedFromMessage) {
const positioning = isViewer ? 'right' : 'left'; const position = isViewer ? 'right' : 'left';
inlineSidebar = ( inlineSidebar = (
<div className={css.sidebarMarginBottom}> <div className={css.sidebarMarginBottom}>
<InlineSidebar <InlineSidebar
threadInfo={item.threadCreatedFromMessage} threadInfo={item.threadCreatedFromMessage}
positioning={positioning} position={position}
/> />
</div> </div>
); );
} }
return ( return (
<React.Fragment> <React.Fragment>
{authorName} {authorName}
▲ Show 20 Lines • Show All 60 Lines • Show Last 20 Lines
View Options

lib/utils/text-utils.js

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines if (messageActionButtons) {
); );
} }
const viewerActionLinks = isViewer ? messageActionLinks : null; const viewerActionLinks = isViewer ? messageActionLinks : null;
const nonViewerActionLinks = !isViewer ? messageActionLinks : null; const nonViewerActionLinks = !isViewer ? messageActionLinks : null;
let inlineSidebar = null; let inlineSidebar = null;
if (item.threadCreatedFromMessage) { if (item.threadCreatedFromMessage) {
const positioning = isViewer ? 'right' : 'left'; const position = isViewer ? 'right' : 'left';
inlineSidebar = ( inlineSidebar = (
<div className={css.sidebarMarginBottom}> <div className={css.sidebarMarginBottom}>
<InlineSidebar <InlineSidebar
threadInfo={item.threadCreatedFromMessage} threadInfo={item.threadCreatedFromMessage}
positioning={positioning} position={position}
/> />
</div> </div>
); );
} }
return ( return (
<React.Fragment> <React.Fragment>
{authorName} {authorName}
▲ Show 20 Lines • Show All 60 Lines • Show Last 20 Lines
View Options

native/chat/inline-sidebar.react.js

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines if (messageActionButtons) {
); );
} }
const viewerActionLinks = isViewer ? messageActionLinks : null; const viewerActionLinks = isViewer ? messageActionLinks : null;
const nonViewerActionLinks = !isViewer ? messageActionLinks : null; const nonViewerActionLinks = !isViewer ? messageActionLinks : null;
let inlineSidebar = null; let inlineSidebar = null;
if (item.threadCreatedFromMessage) { if (item.threadCreatedFromMessage) {
const positioning = isViewer ? 'right' : 'left'; const position = isViewer ? 'right' : 'left';
inlineSidebar = ( inlineSidebar = (
<div className={css.sidebarMarginBottom}> <div className={css.sidebarMarginBottom}>
<InlineSidebar <InlineSidebar
threadInfo={item.threadCreatedFromMessage} threadInfo={item.threadCreatedFromMessage}
positioning={positioning} position={position}
/> />
</div> </div>
); );
} }
return ( return (
<React.Fragment> <React.Fragment>
{authorName} {authorName}
▲ Show 20 Lines • Show All 60 Lines • Show Last 20 Lines
View Options

web/chat/inline-sidebar.react.js

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines if (messageActionButtons) {
); );
} }
const viewerActionLinks = isViewer ? messageActionLinks : null; const viewerActionLinks = isViewer ? messageActionLinks : null;
const nonViewerActionLinks = !isViewer ? messageActionLinks : null; const nonViewerActionLinks = !isViewer ? messageActionLinks : null;
let inlineSidebar = null; let inlineSidebar = null;
if (item.threadCreatedFromMessage) { if (item.threadCreatedFromMessage) {
const positioning = isViewer ? 'right' : 'left'; const position = isViewer ? 'right' : 'left';
inlineSidebar = ( inlineSidebar = (
<div className={css.sidebarMarginBottom}> <div className={css.sidebarMarginBottom}>
<InlineSidebar <InlineSidebar
threadInfo={item.threadCreatedFromMessage} threadInfo={item.threadCreatedFromMessage}
positioning={positioning} position={position}
/> />
</div> </div>
); );
} }
return ( return (
<React.Fragment> <React.Fragment>
{authorName} {authorName}
▲ Show 20 Lines • Show All 60 Lines • Show Last 20 Lines