Page MenuHomePhabricator
Differential D3963

[native] [fix] [ENG-1099] fix hot reload compose component
ClosedPublic
Actions

Authored by • benschac on May 6 2022, 1:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 6, 9:15 PM
Unknown Object (File)
Fri, Dec 6, 4:21 PM
Unknown Object (File)
Sat, Nov 30, 5:55 AM
Unknown Object (File)
Wed, Nov 27, 4:20 AM
Unknown Object (File)
Wed, Nov 27, 3:07 AM
Unknown Object (File)
Wed, Nov 27, 1:32 AM
Unknown Object (File)
Nov 23 2024, 11:43 AM
Unknown Object (File)
Nov 13 2024, 10:50 AM
View All Files
Subscribers
• adrian
ashoat

Details

Reviewers
atul
tomek
• jacek
• abosh
ashoat
Commits
rCOMM7a4b2a0a7264: [native] [fix] [ENG-1099] fix hot reload compose component
Summary

https://linear.app/comm/issue/ENG-1099/refactor-composed-message-component-to-fix-hot-reload

Test Plan

when editing compose component, it shouldn't move the developer back to inbox

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• benschac created this revision.May 6 2022, 1:42 PM
Herald added subscribers: • adrian, ashoat. · View Herald TranscriptMay 6 2022, 1:42 PM
• benschac added inline comments.May 6 2022, 1:45 PM
native/chat/composed-message-constants.js
3 ↗(On Diff #12388)

We don't have a set way/place to throw constants yet. Open to any suggestions. just made a new file for the moment. Having a constants file for chat would make sense in the long term.

• benschac added a parent revision: D3915: [web,native,lib] [refactor] [ENG-530] rename hook to useInlineEngagement from useInlineText.May 6 2022, 1:47 PM
Harbormaster completed remote builds in B8885: Diff 12388.May 6 2022, 1:47 PM
• benschac requested review of this revision.May 6 2022, 1:47 PM
ashoat accepted this revision.May 6 2022, 7:53 PM
ashoat added inline comments.
native/chat/composed-message.react.js
223 ↗(On Diff #12388)

We should probably export default ConnectedComposedMessage since it's just the one component now

This revision is now accepted and ready to land.May 6 2022, 7:53 PM
• benschac updated this revision to Diff 12445.May 9 2022, 10:02 AM

address diff comment

native/chat/composed-message.react.js
223 ↗(On Diff #12388)

makes sense

Harbormaster completed remote builds in B8936: Diff 12445.May 9 2022, 10:07 AM
Closed by commit rCOMM7a4b2a0a7264: [native] [fix] [ENG-1099] fix hot reload compose component (authored by • benschac). · Explain WhyMay 9 2022, 10:08 AM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMM7a4b2a0a7264: [native] [fix] [ENG-1099] fix hot reload compose component.

Revision Contents
Changeset List

Diff 12446

View Options

native/chat/composed-message-constants.js

Loading...
View Options

native/chat/composed-message.react.js

Loading...
View Options

native/chat/message-header.react.js

Loading...
View Options

native/chat/multimedia-message-utils.js

Loading...
View Options

native/chat/multimedia-message.react.js

Loading...
View Options

native/chat/text-message.react.js

Loading...
View Options

native/chat/utils.js

Loading...