Page MenuHomePhabricator

[native] [fix] [ENG-1099] fix hot reload compose component
ClosedPublic

Authored by benschac on May 6 2022, 1:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 20, 5:38 AM
Unknown Object (File)
Thu, Feb 20, 5:38 AM
Unknown Object (File)
Thu, Feb 20, 5:38 AM
Unknown Object (File)
Thu, Feb 20, 5:38 AM
Unknown Object (File)
Thu, Feb 20, 5:35 AM
Unknown Object (File)
Sun, Feb 16, 3:32 AM
Unknown Object (File)
Thu, Feb 13, 8:51 AM
Unknown Object (File)
Sun, Feb 9, 9:33 AM
Subscribers

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

native/chat/composed-message-constants.js
3 ↗(On Diff #12388)

We don't have a set way/place to throw constants yet. Open to any suggestions. just made a new file for the moment. Having a constants file for chat would make sense in the long term.

ashoat added inline comments.
native/chat/composed-message.react.js
223 ↗(On Diff #12388)

We should probably export default ConnectedComposedMessage since it's just the one component now

This revision is now accepted and ready to land.May 6 2022, 7:53 PM

address diff comment

native/chat/composed-message.react.js
223 ↗(On Diff #12388)

makes sense