Move errorMessage out of the inner class component state, and move it out to the wrapping "Connected" functional component.
As part of the work to refactor ThreadSettingsModal… specifically to turn it into a functional component.
Differential D3756
[web] Move `errorMessage` state up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal` atul on Apr 18 2022, 10:25 AM. Authored by Tags None Referenced Files
Subscribers
Details Move errorMessage out of the inner class component state, and move it out to the wrapping "Connected" functional component. As part of the work to refactor ThreadSettingsModal… specifically to turn it into a functional component.
Note: The error message styling (showing up to the right of the button) isn't great. That's "on the todo list" and will be handled once the "noop" refactorings are complete.
Diff Detail
Event TimelineComment Actions Why is this necessary? Each diff should "stand on its own" and be reviewable without additional context. "As part of the work to refactor ThreadSettingsModal" is not enough of an explanation for me to understand why this state needs to be lifted. If the explanation is in another diff, a simple link to that diff should be enough! Comment Actions Cool, that's helpful. Please edit the diff description of every diff to include that info! |