Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3513875
D14138.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D14138.diff
View Options
diff --git a/lib/selectors/chat-selectors.js b/lib/selectors/chat-selectors.js
--- a/lib/selectors/chat-selectors.js
+++ b/lib/selectors/chat-selectors.js
@@ -51,18 +51,15 @@
import memoize2 from '../utils/memoize.js';
import { useSelector } from '../utils/redux-utils.js';
-type ChatThreadItemBase = {
+export type ChatThreadItem = {
+type: 'chatThreadItem',
+threadInfo: ThreadInfo,
+mostRecentNonLocalMessage: ?string,
+sidebars: $ReadOnlyArray<SidebarItem>,
+pendingPersonalThreadUserInfo?: UserInfo,
-};
-export type ChatThreadItem = $ReadOnly<{
- ...ChatThreadItemBase,
+lastUpdatedTime: number,
+lastUpdatedTimeIncludingSidebars: number,
-}>;
+};
const messageInfoSelector: (state: BaseAppState<>) => {
+[id: string]: ?MessageInfo,
@@ -82,13 +79,13 @@
);
}
-type CreatedChatThreadItem = $ReadOnly<{
- ...ChatThreadItemBase,
- +lastUpdatedAtLeastTime: number,
+type CreatedChatThreadItem = {
+ +threadInfo: ThreadInfo,
+lastUpdatedAtLeastTimeIncludingSidebars: number,
+lastUpdatedAtMostTimeIncludingSidebars: number,
+ +initialChatThreadItem: ChatThreadItem,
+getFinalChatThreadItem: () => Promise<ChatThreadItem>,
-}>;
+};
function useCreateChatThreadItem(): ThreadInfo => CreatedChatThreadItem {
const messageInfos = useSelector(messageInfoSelector);
const sidebarInfos = useSidebarInfos();
@@ -153,13 +150,19 @@
: lastUpdatedAtMostTime;
const allInitialSidebarItems = getAllInitialSidebarItems(sidebars);
-
- return {
+ const initialChatThreadItem = {
...chatThreadItemBase,
sidebars: getSidebarItems(allInitialSidebarItems),
- lastUpdatedAtLeastTime,
+ lastUpdatedTime: lastUpdatedAtLeastTime,
+ lastUpdatedTimeIncludingSidebars:
+ lastUpdatedAtLeastTimeIncludingSidebars,
+ };
+
+ return {
+ threadInfo,
lastUpdatedAtLeastTimeIncludingSidebars,
lastUpdatedAtMostTimeIncludingSidebars,
+ initialChatThreadItem,
getFinalChatThreadItem,
};
},
@@ -194,21 +197,9 @@
const initialChatThreadItems = React.useMemo(
() =>
- createdChatThreadItems.map(createdChatThreadItem => {
- const {
- lastUpdatedAtLeastTime,
- lastUpdatedAtLeastTimeIncludingSidebars,
- lastUpdatedAtMostTimeIncludingSidebars,
- getFinalChatThreadItem,
- ...rest
- } = createdChatThreadItem;
- return {
- ...rest,
- lastUpdatedTime: lastUpdatedAtLeastTime,
- lastUpdatedTimeIncludingSidebars:
- lastUpdatedAtLeastTimeIncludingSidebars,
- };
- }),
+ createdChatThreadItems.map(
+ createdChatThreadItem => createdChatThreadItem.initialChatThreadItem,
+ ),
[createdChatThreadItems],
);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Dec 23, 2:31 AM (18 h, 30 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2672788
Default Alt Text
D14138.diff (2 KB)
Attached To
Mode
D14138: [lib] Extract initialChatThreadItem
Attached
Detach File
Event Timeline
Log In to Comment