Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F3540295
D4716.id15221.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D4716.id15221.diff
View Options
diff --git a/native/android/app/bash/build_openssl.sh b/native/android/app/bash/build_openssl.sh
--- a/native/android/app/bash/build_openssl.sh
+++ b/native/android/app/bash/build_openssl.sh
@@ -44,7 +44,7 @@
readonly BUILD_PREFIX=$3
echo "Building OpenSSL library for ${BUILD_PREFIX} (${TARGET_ARCH})"
- cd $OPENSSL_SUBMODULE_PATH
+ cd "$OPENSSL_SUBMODULE_PATH"
# Compilation flags:
export CFLAGS="-Os -ffunction-sections -fdata-sections -fno-unwind-tables -fno-asynchronous-unwind-tables"
@@ -53,13 +53,13 @@
export TARGET_HOST=${TARGET_ARCH}
PATH=$TOOLCHAIN/bin:$PATH
- ./config no-asm -Wl,--enable-new-dtags,-rpath,'$(LIBRPATH)'
- ./Configure ${BUILD_ARCH} no-shared \
- -D__ANDROID_API__=$MIN_SDK_VERSION \
- --prefix=$OPENSSL_SUBMODULE_PATH/build/${BUILD_PREFIX}
+ ./config no-asm -Wl,--enable-new-dtags,-rpath,"$(LIBRPATH)"
+ ./Configure "${BUILD_ARCH}" no-shared \
+ -D__ANDROID_API__="$MIN_SDK_VERSION" \
+ --prefix="$OPENSSL_SUBMODULE_PATH"/build/"${BUILD_PREFIX}"
make -j"$THREADS"
make install_sw
make clean
}
-CONFIGURE_AND_BUILD $TARGET_ARCH $BUILD_ARCH $ANDROID_ARCH_ABI
+CONFIGURE_AND_BUILD "$TARGET_ARCH" $BUILD_ARCH "$ANDROID_ARCH_ABI"
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Dec 27, 4:43 AM (2 h, 59 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2709377
Default Alt Text
D4716.id15221.diff (1 KB)
Attached To
Mode
D4716: [native] Clean up `build_openssl.sh` using ShellCheck
Attached
Detach File
Event Timeline
Log In to Comment