[native] Clean up `build_openssl.sh` using ShellCheck
ClosedPublic
Actions

Authored by • abosh on Aug 2 2022, 9:33 AM.

Details

Reviewers

atul
• jon
tomek
ashoat

Commits

rCOMMbf53b585b764: [native] Clean up `build_openssl.sh` using ShellCheck

Summary

Related Linear issue here. This is part of a set of diffs that will allow ShellCheck to be added to the CI. See inline comments for specific details of the ShellCheck error/warning output.

Test Plan

ShellCheck.

Additionally, build_openssl.sh is run during the Android build so if that workflow continues to pass CI we can reasonably assume that the script continues to work as expected.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• abosh created this revision.Aug 2 2022, 9:33 AM

Herald added a subscriber: • adrian. · View Herald TranscriptAug 2 2022, 9:33 AM

Every change made in this file was double quote to prevent globbing and word splitting.

Harbormaster completed remote builds in B11058: Diff 15221.Aug 2 2022, 9:43 AM

• abosh requested review of this revision.Aug 2 2022, 9:43 AM

Outside of running shellcheck, we should ensure that the script continues to work as expected and specify how we can check that in the Test Plan.

eg something like:

build_openssl.sh is run during the Android build so if that workflow continues to pass CI we can reasonably assume that the script continues to work as expected

This revision is now accepted and ready to land.Aug 2 2022, 10:35 AM

In D4716#135609, @atul wrote:

Outside of running shellcheck, we should ensure that the script continues to work as expected and specify how we can check that in the Test Plan.

eg something like:

build_openssl.sh is run during the Android build so if that workflow continues to pass CI we can reasonably assume that the script continues to work as expected

Great point. I'll start doing that from now on/will modify prior diffs. I think because this diff only added double quotes I got lazy and wasn't thorough in the Test Plan.

• abosh edited the test plan for this revision. (Show Details)Aug 2 2022, 10:38 AM

Closed by commit rCOMMbf53b585b764: [native] Clean up `build_openssl.sh` using ShellCheck (authored by • abosh). · Explain WhyAug 2 2022, 2:20 PM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMMbf53b585b764: [native] Clean up `build_openssl.sh` using ShellCheck.

• abosh mentioned this in D4737: [native] Double quote `BUILD_ARCH` in `build_openssl.sh`.Aug 4 2022, 9:57 AM

• abosh mentioned this in rCOMM64de81864af7: [native] Double quote `BUILD_ARCH` in `build_openssl.sh`.Aug 4 2022, 10:45 AM