Differential D6816 Diff 22938 web/modals/apps/apps-directory-modal.react.js

Changeset View

Standalone View

web/modals/apps/apps-directory-modal.react.js

// @flow		// @flow

import * as React from 'react';		import * as React from 'react';
import { useSelector } from 'react-redux';

import { useModalContext } from 'lib/components/modal-provider.react.js';		import { useModalContext } from 'lib/components/modal-provider.react.js';

		import { useSelector } from '../../redux/redux-utils.js';
import AppListing from '../apps/app-listing.react.js';		import AppListing from '../apps/app-listing.react.js';
import css from '../apps/apps.css';		import css from '../apps/apps.css';
import Modal from '../modal.react.js';		import Modal from '../modal.react.js';

const APP_DIRECTORY_DATA = [		const APP_DIRECTORY_DATA = [
{		{
id: 'chat',		id: 'chat',
defaultEnabled: true,		defaultEnabled: true,
Show All 16 Lines	function AppsModal(): React.Node {
const modalContext = useModalContext();		const modalContext = useModalContext();

const enabledApps = useSelector(state => state.enabledApps);		const enabledApps = useSelector(state => state.enabledApps);

const appData = React.useMemo(		const appData = React.useMemo(
() =>		() =>
APP_DIRECTORY_DATA.map(app => {		APP_DIRECTORY_DATA.map(app => {
const { defaultEnabled, ...data } = app;		const { defaultEnabled, ...data } = app;
		if (app.id === 'chat') {
		kamilUnsubmitted Not Done Inline Actions maybe I am missing context here but wondering we there is need to fix this that way, not eg. adding `chat: true` (because it's always enabled) to `EnabledApps` type, since chat is also an app? kamil: maybe I am missing context here but wondering we there is need to fix this that way, not eg.
		inkaAuthorUnsubmitted Done Inline Actions Me and @tomek talked about this and inn result this task was created: https://linear.app/comm/issue/ENG-3061/discuss-making-redux-state-unaware-that-the-chat-tab-is-always-enabled Generally we might want to add `chat` to the state, but maybe not as a `true`, but as a `boolean`, so that the redux doesn't know about the business-logic-specific fact - that the chat tab is always selected. But that also requires some more changes inka: Me and @tomek talked about this and inn result this task was created: https://linear.
return {		return {
...data,		...data,
enabled: enabledApps[app.id] ?? defaultEnabled,		enabled: defaultEnabled,
		};
		}
		return {
		...data,
		enabled: enabledApps[app.id],
};		};
}),		}),
[enabledApps],		[enabledApps],
);		);

const appItems = React.useMemo(		const appItems = React.useMemo(
() => appData.map(item => <AppListing key={item.id} {...item} />),		() => appData.map(item => <AppListing key={item.id} {...item} />),
[appData],		[appData],
Show All 12 Lines