Page MenuHomePhabricator

[web] Change import path and fix errors showing up when the typing is correct

Authored by inka on Tue, Feb 21, 4:26 AM.
Referenced Files
Unknown Object (File)
Sun, Mar 5, 8:22 AM
Unknown Object (File)
Sun, Mar 5, 6:10 AM
Unknown Object (File)
Sat, Mar 4, 4:29 AM
Unknown Object (File)
Fri, Mar 3, 5:29 PM
Unknown Object (File)
Fri, Mar 3, 12:09 AM
Unknown Object (File)
Thu, Mar 2, 6:28 PM
Unknown Object (File)
Thu, Mar 2, 11:50 AM
Unknown Object (File)
Thu, Mar 2, 10:36 AM



As mentioned in D6812 the import has to be fixed. We use useSelector from web/redux/redux-utils.js on web, because it adds proper typing. This change broke this file, because we should not be
quering an object for a field it doesn't have. Thus the other changes.

Test Plan

Run web app, checked that Apps directory modal displays its items correclty.

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Feb 21, 4:34 AM
Harbormaster failed remote builds in B16693: Diff 22826!
inka requested review of this revision.Tue, Feb 21, 6:28 AM
This revision is now accepted and ready to land.Fri, Feb 24, 2:25 AM
40 ↗(On Diff #22938)

maybe I am missing context here but wondering we there is need to fix this that way, not eg. adding chat: true (because it's always enabled) to EnabledApps type, since chat is also an app?

40 ↗(On Diff #22938)

Me and @tomek talked about this and inn result this task was created:

Generally we might want to add chat to the state, but maybe not as a true, but as a boolean, so that the redux doesn't know about the business-logic-specific fact - that the chat tab is always selected. But that also requires some more changes