Page MenuHomePhabricator
Differential D6962 Diff 23475 lib/shared/messages/sidebar-source-message-spec.js

Changeset View

Standalone View

View Options

lib/shared/messages/sidebar-source-message-spec.js

Show First 20 Lines • Show All 99 Lines • ▼ Show 20 Lines createMessageInfo(
params: CreateMessageInfoParams, params: CreateMessageInfoParams,
): ?SidebarSourceMessageInfo { ): ?SidebarSourceMessageInfo {
if (!rawMessageInfo.sourceMessage) { if (!rawMessageInfo.sourceMessage) {
return null; return null;
} }
const sourceMessage = params.createMessageInfoFromRaw( const sourceMessage = params.createMessageInfoFromRaw(
rawMessageInfo.sourceMessage, rawMessageInfo.sourceMessage,
); );
invariant( invariant(
sourceMessage && sourceMessage &&
sourceMessage.type !== messageTypes.SIDEBAR_SOURCE && sourceMessage.type !== messageTypes.SIDEBAR_SOURCE &&
sourceMessage.type !== messageTypes.REACTION, sourceMessage.type !== messageTypes.REACTION &&
'Sidebars can not be created from SIDEBAR SOURCE OR REACTION', sourceMessage.type !== messageTypes.EDIT_MESSAGE,
'Sidebars can not be created from SIDEBAR SOURCE, REACTION or EDIT MESSAGE',
); );
ginsuUnsubmitted
Not Done
Inline Actions

When I was working on reactions, @tomek recommended defining a set of incompatible messages with the sidebar source. Now that we have more than two incompatible messages, now might be a good time to address this

https://linear.app/comm/issue/ENG-2422/define-set-of-incompatible-message-types-for-sidebar-source

ginsu: When I was working on reactions, @tomek recommended defining a set of incompatible messages…
kubaAuthorUnsubmitted
Done
Inline Actions

Added as follow-up task to message editing

kuba: Added as follow-up task to message editing
return { return {
type: messageTypes.SIDEBAR_SOURCE, type: messageTypes.SIDEBAR_SOURCE,
id: rawMessageInfo.id, id: rawMessageInfo.id,
threadID: rawMessageInfo.threadID, threadID: rawMessageInfo.threadID,
creator, creator,
time: rawMessageInfo.time, time: rawMessageInfo.time,
sourceMessage, sourceMessage,
▲ Show 20 Lines • Show All 56 Lines • Show Last 20 Lines