[lib][keyserver] Add editing message type to messageTypes
ClosedPublic
Actions

Authored by • kuba on Mar 7 2023, 1:34 AM.

Details

Reviewers

michal
inka
ginsu

Commits

rCOMMa769bb18d4d0: [lib][keyserver] Add editing message type to messageTypes

Summary

Registered new message type EDIT_MESSAGE to messageTypes. Added some lines to prevent flow-typing errors in different places of the app. For now, when we process the added
message type, we ignore it.

Test Plan

Tested if app compiles and checked if everything works correctly.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• kuba created this revision.Mar 7 2023, 1:34 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 7 2023, 1:34 AM

• kuba added a parent revision: D6961: [lib] Create types for message editing.Mar 7 2023, 1:34 AM

• kuba added a child revision: D6963: [lib] Added new MessageSpec for editing messages.Mar 7 2023, 1:40 AM

Harbormaster completed remote builds in B17135: Diff 23475.Mar 7 2023, 1:49 AM

• kuba requested review of this revision.Mar 7 2023, 1:49 AM

• kuba added a reviewer: ginsu.Mar 7 2023, 8:11 AM

Accepting, but if what I suggested doesn't take too long might be worthwhile to update

lib/shared/messages/sidebar-source-message-spec.js
108–114	When I was working on reactions, @tomek recommended defining a set of incompatible messages with the sidebar source. Now that we have more than two incompatible messages, now might be a good time to address this https://linear.app/comm/issue/ENG-2422/define-set-of-incompatible-message-types-for-sidebar-source