Page MenuHomePhabricator

kuba (Jakub Kosmydel)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2023, 3:12 AM (6 w, 5 d)

Recent Activity

Fri, Mar 24

kuba updated the diff for D7065: [native] Added displaying labels to InlineEngagement.

Rebase

Fri, Mar 24, 5:35 AM
kuba updated the diff for D7063: [native] Move 'InlineEngagement' styling from 'ComposedMessage' to component.

Rebase

Fri, Mar 24, 5:32 AM
kuba updated the diff for D7145: [keyserver] Adding edit_message to the sidebar thread.

Address comments

Fri, Mar 24, 3:56 AM
kuba added inline comments to D7129: [lib] Added new 'sendEditMessage' action.
Fri, Mar 24, 3:54 AM
kuba updated the diff for D7129: [lib] Added new 'sendEditMessage' action.

Change type to inexact

Fri, Mar 24, 3:54 AM
kuba added inline comments to D7143: [lib] Function to dispatch edit message action.
Fri, Mar 24, 3:39 AM
kuba updated the diff for D7143: [lib] Function to dispatch edit message action.

Address review comments

Fri, Mar 24, 3:38 AM
kuba updated the diff for D7140: [lib] Displaying edited content in a pending thread.

Address comments

Fri, Mar 24, 3:09 AM
kuba added a comment to D6965: [lib][native] Displaying edited messages from database.

We can consider preventing users from sending empty edit messages.

We should do this. We don't allow empty messages for messageTypes.TEXT. Can you create a follow-up Linear task for this before landing?

Fri, Mar 24, 2:57 AM

Thu, Mar 23

kuba added inline comments to D7141: [keyserver] Add the latest edit message to the new sidebar if the source message is edited.
Thu, Mar 23, 8:43 AM
kuba updated the diff for D7141: [keyserver] Add the latest edit message to the new sidebar if the source message is edited.

Addressed some of the comments

Thu, Mar 23, 8:43 AM

Wed, Mar 22

kuba updated the test plan for D7066: [native] Displaying 'Edit' labels next to edited messages.
Wed, Mar 22, 1:09 PM
kuba requested review of D7145: [keyserver] Adding edit_message to the sidebar thread.
Wed, Mar 22, 6:39 AM
kuba requested review of D7144: [lib] Added edit message action reducer.
Wed, Mar 22, 6:37 AM
kuba requested review of D7143: [lib] Function to dispatch edit message action.
Wed, Mar 22, 6:19 AM
kuba requested review of D7142: [lib] Checking if the user can edit the message.
Wed, Mar 22, 6:16 AM
kuba requested review of D7140: [lib] Displaying edited content in a pending thread.
Wed, Mar 22, 6:12 AM
kuba requested review of D7141: [keyserver] Add the latest edit message to the new sidebar if the source message is edited.
Wed, Mar 22, 6:11 AM
kuba requested review of D7139: [lib] Added method to call edit_message endpoint.
Wed, Mar 22, 5:58 AM
kuba added inline comments to D6965: [lib][native] Displaying edited messages from database.
Wed, Mar 22, 5:23 AM
kuba updated the diff for D6965: [lib][native] Displaying edited messages from database.

Revert the changes

Wed, Mar 22, 5:23 AM
kuba retitled D6965: [lib][native] Displaying edited messages from database from [lib][native] Displaying edited messages from database to [lib] Displaying edited messages from database.
Wed, Mar 22, 5:23 AM
kuba updated the diff for D6965: [lib][native] Displaying edited messages from database.

Simplified condition

Wed, Mar 22, 5:14 AM
kuba added inline comments to D6963: [lib] Added new MessageSpec for editing messages.
Wed, Mar 22, 5:09 AM
kuba updated the diff for D6963: [lib] Added new MessageSpec for editing messages.

Added message type for error message

Wed, Mar 22, 5:06 AM
kuba updated the diff for D6961: [lib] Create types for message editing.

id is no longer nullable

Wed, Mar 22, 5:01 AM
kuba added a comment to D6961: [lib] Create types for message editing.

Can you clarify in what scenarios the id can be null? Usually we only see that for types that also have localID

Wed, Mar 22, 4:59 AM
kuba updated the diff for D7128: [lib][keyserver] Added new edit_message endpoint.

Simplified text variable

Wed, Mar 22, 4:51 AM
kuba updated the diff for D7065: [native] Added displaying labels to InlineEngagement.

Added unique keys to the rendered components

Wed, Mar 22, 4:40 AM

Tue, Mar 21

kuba requested review of D7129: [lib] Added new 'sendEditMessage' action.
Tue, Mar 21, 11:52 AM
kuba requested review of D7128: [lib][keyserver] Added new edit_message endpoint.
Tue, Mar 21, 11:45 AM
kuba requested review of D7127: [lib][keyserver] Introduce new threadPermissions types for editing messages.
Tue, Mar 21, 11:37 AM
kuba updated the diff for D7065: [native] Added displaying labels to InlineEngagement.

Addressed @ginsu feedback from the web version of diff

Tue, Mar 21, 11:16 AM
kuba planned changes to D7065: [native] Added displaying labels to InlineEngagement.

The same comments as in: https://phab.comm.dev/D7017?id=23714#inline-46406

Tue, Mar 21, 10:42 AM
kuba added inline comments to D7017: [web] Added displaying 'Labels' to InlineEngagment.
Tue, Mar 21, 10:41 AM
kuba updated the diff for D7017: [web] Added displaying 'Labels' to InlineEngagment.

Addressed @ginsu comments

Tue, Mar 21, 10:40 AM
kuba added a comment to D7017: [web] Added displaying 'Labels' to InlineEngagment.
In D7017#210367, @ginsu wrote:

Also, I personally feel like the label for edited messages should be below the reactions/threads and not to the left/right of it. Could you link or send a screenshot of what the figma has?

Tue, Mar 21, 10:15 AM
kuba updated the diff for D6961: [lib] Create types for message editing.

Removed localID from the type

Tue, Mar 21, 1:49 AM
kuba abandoned D6393: Fixed incorret display for long thread names on web..

@inka fixed this in another diff.

Tue, Mar 21, 12:33 AM

Wed, Mar 15

kuba added a comment to D7017: [web] Added displaying 'Labels' to InlineEngagment.

Can you share an updated screenshot?

Wed, Mar 15, 12:16 PM

Tue, Mar 14

kuba updated the diff for D7017: [web] Added displaying 'Labels' to InlineEngagment.

Aligned 'Delivery failed' notice to the message label. Only for the right side, because we can't get delivery failed on the left side.

Tue, Mar 14, 7:37 AM
kuba added a comment to D6963: [lib] Added new MessageSpec for editing messages.
In D6963#209536, @tomek wrote:

The proper way of testing older clients involves running an older client in prod mode (so that it won't get hot reloaded when we update the code version), then checking out the newest code, and running the server with this code. In this case we can consider a simplified approach: the thing which interests us the most is if the server sends an original message or the shimmed version. To test that we can run a client and set code version in the condition on the keyserver. If the client's version is higher than server's, we should receive an original message. Otherwise, it should be the shimmed one.

Tue, Mar 14, 3:06 AM
kuba updated the diff for D6963: [lib] Added new MessageSpec for editing messages.

Changed minCodeVersion for messageShimming

Tue, Mar 14, 2:51 AM
kuba requested review of D7066: [native] Displaying 'Edit' labels next to edited messages.
Tue, Mar 14, 2:10 AM
kuba requested review of D7065: [native] Added displaying labels to InlineEngagement.
Tue, Mar 14, 2:07 AM
kuba requested review of D7063: [native] Move 'InlineEngagement' styling from 'ComposedMessage' to component.
Tue, Mar 14, 1:53 AM
kuba added a comment to D6963: [lib] Added new MessageSpec for editing messages.

I don't know how to test message shimming yet, so for now it isn't tested.

Tue, Mar 14, 1:10 AM
kuba updated the diff for D6963: [lib] Added new MessageSpec for editing messages.

Added shimming message info, changed content to JSON format.

Tue, Mar 14, 1:09 AM

Mon, Mar 13

kuba added a comment to D7017: [web] Added displaying 'Labels' to InlineEngagment.

Can you check what it looks like with the "Delivery failed. RETRY?" text which appears when sending a message, and attach a screenshot? Not sure if this case was considered in the designs.

Mon, Mar 13, 10:14 AM
kuba attached a referenced file: F425177: Screenshot 2023-03-13 at 11.24.47.png.
Mon, Mar 13, 3:34 AM
kuba added a comment to D6963: [lib] Added new MessageSpec for editing messages.
In D6963#208218, @ginsu wrote:

I think we should consider if we also need shimUnsupportedMessageInfo and unshimMessageInfo. These functions will help us support older native clients that haven't been updated yet.

Mon, Mar 13, 3:32 AM
kuba updated the diff for D6963: [lib] Added new MessageSpec for editing messages.

Responded to comments

Mon, Mar 13, 3:32 AM

Thu, Mar 9

kuba requested review of D7018: [web] Displaying 'Edit' label next to edited messages.
Thu, Mar 9, 3:57 AM
kuba requested review of D7017: [web] Added displaying 'Labels' to InlineEngagment.
Thu, Mar 9, 3:50 AM
kuba updated the diff for D6966: [lib] Add 'hasBeenEdited' status to messages.

Removed 'hasBeenEdited' variable from 'RobotextChatMessageInfoItem'

Thu, Mar 9, 1:50 AM
kuba updated the diff for D6966: [lib] Add 'hasBeenEdited' status to messages.

Add 'hasBeenEdited' to code for native to be able to access the variable

Thu, Mar 9, 1:30 AM

Wed, Mar 8

kuba added a comment to D6966: [lib] Add 'hasBeenEdited' status to messages.

Can we avoid putting this in TextMessageInfo? I don't think it belongs there... and you're doing something pretty inconsistent with how we approached reactions.

Why didn't you put this in ChatMessageInfoItem? (In the future, when you are doing something different like this, please expect that your reviewers will call you out on it, and explain it ahead of time.)

Wed, Mar 8, 10:00 AM
kuba updated the diff for D6966: [lib] Add 'hasBeenEdited' status to messages.

Moved 'hasBeenEdited' property to 'ChatMessageInfoItem' type

Wed, Mar 8, 10:00 AM
kuba updated the diff for D6966: [lib] Add 'hasBeenEdited' status to messages.

Responded to comments, made hasBeenEdited property read-only

Wed, Mar 8, 3:08 AM
kuba updated the diff for D6965: [lib][native] Displaying edited messages from database.

Responded to comments, made read-only 'text' property

Wed, Mar 8, 2:59 AM

Tue, Mar 7

kuba added a reviewer for D6965: [lib][native] Displaying edited messages from database: ginsu.
Tue, Mar 7, 8:11 AM
kuba added a reviewer for D6964: [native] Added new editing messages type to MessageSpecs in C++: ginsu.
Tue, Mar 7, 8:11 AM
kuba added a reviewer for D6963: [lib] Added new MessageSpec for editing messages: ginsu.
Tue, Mar 7, 8:11 AM
kuba added a reviewer for D6962: [lib][keyserver] Add editing message type to messageTypes: ginsu.
Tue, Mar 7, 8:11 AM
kuba added a reviewer for D6961: [lib] Create types for message editing: ginsu.
Tue, Mar 7, 8:10 AM
kuba added a comment to D6961: [lib] Create types for message editing.

Can you also updates lib/types/messages.js? EDIT ah I see these are in the next diff

In general I personally find it better to introduce types along with code that actually uses them, but many people on the team do what you did here and introduce them in a separate diff. It just makes it much harder to test... eg. your Test Plan doesn't actually test any of the types at all, which means it's quite a poor test plan.

Tue, Mar 7, 8:10 AM
kuba updated the test plan for D6965: [lib][native] Displaying edited messages from database.
Tue, Mar 7, 2:01 AM
kuba requested review of D6966: [lib] Add 'hasBeenEdited' status to messages.
Tue, Mar 7, 2:00 AM
kuba requested review of D6965: [lib][native] Displaying edited messages from database.
Tue, Mar 7, 1:59 AM
kuba requested review of D6964: [native] Added new editing messages type to MessageSpecs in C++.
Tue, Mar 7, 1:56 AM
kuba requested review of D6963: [lib] Added new MessageSpec for editing messages.
Tue, Mar 7, 1:54 AM
kuba requested review of D6962: [lib][keyserver] Add editing message type to messageTypes.
Tue, Mar 7, 1:49 AM
kuba requested review of D6961: [lib] Create types for message editing.
Tue, Mar 7, 1:47 AM

Tue, Feb 28

kuba updated the diff for D5518: [web] Unify behaviour of chat composer with native.

Fixing wrong rebasing

Tue, Feb 28, 3:25 AM
kuba updated the diff for D5583: [web] Change alert type in UserListItem.

Another try to fix rebasing

Tue, Feb 28, 3:23 AM
kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Rebase

Tue, Feb 28, 3:22 AM
kuba updated the diff for D5583: [web] Change alert type in UserListItem.

Rebase

Tue, Feb 28, 3:17 AM

Mon, Feb 27

kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Undo rebase

Mon, Feb 27, 4:49 AM
kuba updated the diff for D5518: [web] Unify behaviour of chat composer with native.

Rebase

Mon, Feb 27, 4:33 AM
kuba updated the diff for D5583: [web] Change alert type in UserListItem.

Rebase

Mon, Feb 27, 4:32 AM
kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Rebase

Mon, Feb 27, 4:32 AM
kuba updated the diff for D5462: [keyserver] Update userStore from chat creation url.

Rebase

Mon, Feb 27, 4:32 AM
kuba planned changes to D5463: [web] Call searchUsers in chat composer.
Mon, Feb 27, 4:29 AM
kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Fixed according to Michal notes

Mon, Feb 27, 4:28 AM

Feb 24 2023

kuba removed reviewers for D5463: [web] Call searchUsers in chat composer: atul, abosh.
Feb 24 2023, 4:07 AM
kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Used function from the lib instead of rewriting it

Feb 24 2023, 4:06 AM
kuba planned changes to D5463: [web] Call searchUsers in chat composer.
Feb 24 2023, 3:56 AM
kuba updated the diff for D5583: [web] Change alert type in UserListItem.

Rebase - parent update

Feb 24 2023, 3:46 AM
kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Removed deepclone, surrounded dispatch with if in case of empty payload

Feb 24 2023, 3:40 AM

Feb 23 2023

kuba updated the test plan for D6846: [native] Deleted react-native-exit-app library.
Feb 23 2023, 6:01 AM
kuba requested review of D6846: [native] Deleted react-native-exit-app library.
Feb 23 2023, 5:38 AM
kuba requested review of D6844: [native] Replaced react-native-exit-app calls with CommCoreModule calls.
Feb 23 2023, 4:11 AM
kuba retitled D6834: [native] Added terminate() implementation in JS and CommCoreModule from [native] Removed `react-native-exit-app` library to [native] Added terminate() implementation in JS and CommCoreModule.
Feb 23 2023, 3:50 AM
kuba updated the diff for D6834: [native] Added terminate() implementation in JS and CommCoreModule.

Removed added unintentionally "TODO"

Feb 23 2023, 3:46 AM
kuba updated the diff for D6834: [native] Added terminate() implementation in JS and CommCoreModule.

Splitting into 3 diffs

Feb 23 2023, 3:43 AM
kuba added a comment to D6834: [native] Added terminate() implementation in JS and CommCoreModule.

@kuba, have you worked with a diff stack before? This might be a good opportunity to learn!

Feb 23 2023, 2:11 AM
kuba planned changes to D6834: [native] Added terminate() implementation in JS and CommCoreModule.
Feb 23 2023, 2:10 AM
kuba updated the diff for D5518: [web] Unify behaviour of chat composer with native.

Lint error after rebase

Feb 23 2023, 1:53 AM
kuba updated the diff for D5518: [web] Unify behaviour of chat composer with native.

Rebase again

Feb 23 2023, 1:43 AM
kuba updated the diff for D5583: [web] Change alert type in UserListItem.

Updated parent - rebase

Feb 23 2023, 1:31 AM