Page MenuHomePhabricator

kuba (Jakub Kosmydel)
Disabled

Projects

User does not belong to any projects.

User Details

User Since
Feb 7 2023, 3:12 AM (71 w, 5 d)
Roles
Disabled

Recent Activity

Jul 13 2023

kuba updated the diff for D8271: [native] Unblock scrolling when continuing editing.

Review

Jul 13 2023, 1:39 AM
kuba updated the diff for D8271: [native] Unblock scrolling when continuing editing.

Address review

Jul 13 2023, 12:19 AM

Jul 12 2023

kuba added 1 blocking reviewer(s) for D8271: [native] Unblock scrolling when continuing editing: ashoat.
Jul 12 2023, 4:25 AM

Jul 11 2023

kuba added inline comments to D8027: [web] Scrolling to the edited message when it overflows.
Jul 11 2023, 10:47 PM
kuba attached a referenced file: F631317: Screenshot 2023-07-11 at 13.33.27.png.
Jul 11 2023, 10:47 PM
kuba updated the diff for D8271: [native] Unblock scrolling when continuing editing.

Use useCallback

Jul 11 2023, 10:45 PM
kuba added inline comments to D8271: [native] Unblock scrolling when continuing editing.
Jul 11 2023, 5:43 AM
kuba added inline comments to D8027: [web] Scrolling to the edited message when it overflows.
Jul 11 2023, 4:38 AM
kuba updated the diff for D8027: [web] Scrolling to the edited message when it overflows.

Fix comments

Jul 11 2023, 4:38 AM
kuba added a comment to D8271: [native] Unblock scrolling when continuing editing.

Sorry, for the delay in the response, I had an exam session.

Jul 11 2023, 12:43 AM
kuba updated the diff for D8271: [native] Unblock scrolling when continuing editing.

Add resetScrollBlockingModalStatus function

Jul 11 2023, 12:42 AM
kuba updated the diff for D7630: [native] Blocking navigation in edit mode in ChatRouter.

Early exit in componentDidMount

Jul 11 2023, 12:25 AM

Jul 6 2023

kuba updated the diff for D7630: [native] Blocking navigation in edit mode in ChatRouter.

Shorthand

Jul 6 2023, 3:17 AM
kuba updated the diff for D8027: [web] Scrolling to the edited message when it overflows.

Added comments

Jul 6 2023, 3:15 AM
kuba added a comment to D8271: [native] Unblock scrolling when continuing editing.

Requesting review to

Jul 6 2023, 2:32 AM

Jul 5 2023

kuba updated the diff for D8271: [native] Unblock scrolling when continuing editing.

Removed unused OverlayContext

Jul 5 2023, 1:09 AM
kuba updated the diff for D8027: [web] Scrolling to the edited message when it overflows.

Move constants to seperate file

Jul 5 2023, 1:05 AM
kuba updated the diff for D7630: [native] Blocking navigation in edit mode in ChatRouter.

Address review

Jul 5 2023, 12:43 AM
kuba added a comment to D8271: [native] Unblock scrolling when continuing editing.

Hey, sorry for the miscommunication. Here are answers to your questions:

  1. A video showing the bug you are fixing
Jul 5 2023, 12:20 AM

Jul 4 2023

kuba added a comment to D8271: [native] Unblock scrolling when continuing editing.

Updated with a new approach:
when the user is in edit mode the modals scrolling is always unlocked.

Jul 4 2023, 3:08 AM
kuba updated the diff for D8271: [native] Unblock scrolling when continuing editing.

Address review

Jul 4 2023, 3:07 AM

Jul 3 2023

kuba requested review of D7630: [native] Blocking navigation in edit mode in ChatRouter.
Jul 3 2023, 8:08 AM
kuba attached a referenced file: F618688: Screenshot 2023-07-03 at 16.51.02.png.
Jul 3 2023, 8:07 AM
kuba attached a referenced file: F618689: Screenshot 2023-07-03 at 16.52.40.png.
Jul 3 2023, 8:06 AM
kuba added inline comments to D8027: [web] Scrolling to the edited message when it overflows.
Jul 3 2023, 8:05 AM
kuba updated the diff for D8027: [web] Scrolling to the edited message when it overflows.

Address review

Jul 3 2023, 8:05 AM
kuba planned changes to D7630: [native] Blocking navigation in edit mode in ChatRouter.
Jul 3 2023, 5:18 AM
kuba updated the diff for D7630: [native] Blocking navigation in edit mode in ChatRouter.

Added blur and focus listeners

Jul 3 2023, 5:18 AM
kuba planned changes to D7630: [native] Blocking navigation in edit mode in ChatRouter.
Jul 3 2023, 5:18 AM
kuba requested review of D7630: [native] Blocking navigation in edit mode in ChatRouter.
Jul 3 2023, 4:49 AM
kuba added inline comments to D7630: [native] Blocking navigation in edit mode in ChatRouter.
Jul 3 2023, 4:49 AM
kuba planned changes to D7630: [native] Blocking navigation in edit mode in ChatRouter.
Jul 3 2023, 3:25 AM
kuba added inline comments to D7630: [native] Blocking navigation in edit mode in ChatRouter.
Jul 3 2023, 3:25 AM
kuba updated the diff for D7630: [native] Blocking navigation in edit mode in ChatRouter.

Address review: changed removeEditMode return type

Jul 3 2023, 3:24 AM
kuba requested review of D8411: [native] Refactor exitEditAlert function.
Jul 3 2023, 3:18 AM

Jun 27 2023

kuba added 1 blocking reviewer(s) for D7630: [native] Blocking navigation in edit mode in ChatRouter: tomek.
Jun 27 2023, 1:46 AM
kuba added inline comments to D7630: [native] Blocking navigation in edit mode in ChatRouter.
Jun 27 2023, 1:45 AM
kuba updated the diff for D8270: [native] Blocking navigation in edit mode in OverlayRouter.

Rebase & fix calling dispatch from reducer

Jun 27 2023, 1:39 AM
kuba updated the diff for D8304: [native] Blocking navigation in edit mode in the TabRouter.

Rebase & fix calling dispatch from reducer

Jun 27 2023, 1:38 AM
kuba updated the diff for D7630: [native] Blocking navigation in edit mode in ChatRouter.

Remove calling dispatch from reducer

Jun 27 2023, 1:24 AM
kuba updated the diff for D8304: [native] Blocking navigation in edit mode in the TabRouter.

Change to function syntax

Jun 27 2023, 12:25 AM
kuba updated the diff for D7630: [native] Blocking navigation in edit mode in ChatRouter.

Change to function syntax

Jun 27 2023, 12:21 AM
kuba updated the diff for D8027: [web] Scrolling to the edited message when it overflows.

Rebase

Jun 27 2023, 12:10 AM

Jun 26 2023

kuba added inline comments to D7630: [native] Blocking navigation in edit mode in ChatRouter.
Jun 26 2023, 12:36 AM
kuba updated the diff for D7630: [native] Blocking navigation in edit mode in ChatRouter.

address review

Jun 26 2023, 12:36 AM
kuba added inline comments to D8270: [native] Blocking navigation in edit mode in OverlayRouter.
Jun 26 2023, 12:34 AM
kuba updated the diff for D8270: [native] Blocking navigation in edit mode in OverlayRouter.

Address review

Jun 26 2023, 12:10 AM
kuba updated the diff for D8271: [native] Unblock scrolling when continuing editing.

Address review

Jun 26 2023, 12:06 AM

Jun 23 2023

kuba requested review of D8304: [native] Blocking navigation in edit mode in the TabRouter.
Jun 23 2023, 5:17 AM
kuba requested review of D8303: [native] Add a custom TabNavigator.
Jun 23 2023, 5:17 AM
kuba added inline comments to D8270: [native] Blocking navigation in edit mode in OverlayRouter.
Jun 23 2023, 5:17 AM
kuba added inline comments to D7630: [native] Blocking navigation in edit mode in ChatRouter.
Jun 23 2023, 5:04 AM
kuba updated the diff for D7630: [native] Blocking navigation in edit mode in ChatRouter.

Address review & fix issue with nested threads (unblocking the navigation didn't work correctly)

Jun 23 2023, 5:04 AM
kuba updated the test plan for D8270: [native] Blocking navigation in edit mode in OverlayRouter.
Jun 23 2023, 2:42 AM
kuba updated the diff for D8270: [native] Blocking navigation in edit mode in OverlayRouter.

Refactor

Jun 23 2023, 2:14 AM

Jun 21 2023

kuba requested review of D8271: [native] Unblock scrolling when continuing editing.
Jun 21 2023, 3:20 AM
kuba requested review of D8270: [native] Blocking navigation in edit mode in OverlayRouter.
Jun 21 2023, 3:18 AM
kuba retitled D7630: [native] Blocking navigation in edit mode in ChatRouter from [native] Blocking navigation in edit mode to [native] Blocking navigation in edit mode in ChatRouter.
Jun 21 2023, 3:03 AM
kuba updated the diff for D7630: [native] Blocking navigation in edit mode in ChatRouter.

Refactor

Jun 21 2023, 3:00 AM

Jun 20 2023

kuba planned changes to D7630: [native] Blocking navigation in edit mode in ChatRouter.
Jun 20 2023, 7:05 AM
kuba added inline comments to D7630: [native] Blocking navigation in edit mode in ChatRouter.
Jun 20 2023, 7:04 AM
kuba updated the diff for D7630: [native] Blocking navigation in edit mode in ChatRouter.

Address review

Jun 20 2023, 7:01 AM
kuba updated the diff for D7630: [native] Blocking navigation in edit mode in ChatRouter.

Reformat

Jun 20 2023, 6:56 AM
kuba added inline comments to D8027: [web] Scrolling to the edited message when it overflows.
Jun 20 2023, 3:28 AM
kuba updated the diff for D8027: [web] Scrolling to the edited message when it overflows.

Address @inka comments, disable anchor-overflow when in edit mode

Jun 20 2023, 3:26 AM

Jun 16 2023

kuba added inline comments to D8240: [web] Add message search modal.
Jun 16 2023, 7:42 AM
kuba added inline comments to D8027: [web] Scrolling to the edited message when it overflows.
Jun 16 2023, 4:26 AM
kuba updated the diff for D8027: [web] Scrolling to the edited message when it overflows.

Address review

Jun 16 2023, 4:22 AM

Jun 15 2023

kuba updated the summary of D8224: [web] Unify behaviour of chat composer with native.
Jun 15 2023, 1:48 AM
kuba requested review of D8223: [web] Change alert type in UserListItem.
Jun 15 2023, 1:46 AM
kuba requested review of D8224: [web] Unify behaviour of chat composer with native.
Jun 15 2023, 1:42 AM
kuba abandoned D5518: [web] Unify behaviour of chat composer with native.

New version: https://phab.comm.dev/D8224 (to prevent rebase issues)

Jun 15 2023, 1:30 AM
kuba abandoned D5583: [web] Change alert type in UserListItem.

New version in a new stack: https://phab.comm.dev/D8223

Jun 15 2023, 1:22 AM
kuba updated the diff for D6744: [keyserver] Block creating new chats with users that you are not friends with.

Rebase & new stack

Jun 15 2023, 1:19 AM
kuba abandoned D5462: [keyserver] Update userStore from chat creation url.

As discussed with @michal, it is now done with a different approach.

Jun 15 2023, 1:13 AM

Jun 14 2023

kuba added a comment to D8027: [web] Scrolling to the edited message when it overflows.

After a discussion with @inka we decided to add dynamic height calculation. Now, the maximum height of the edit box will be adjusted to the container height. We will scroll to the edited message only when there is insufficient space for the 150px text area in the edit box.

Jun 14 2023, 6:03 AM
kuba updated the diff for D8027: [web] Scrolling to the edited message when it overflows.

Added dynamic maximum height, addressed review

Jun 14 2023, 5:52 AM
kuba abandoned D5463: [web] Call searchUsers in chat composer.

@michal created a new stack with this feature: https://phab.comm.dev/D8013

Jun 14 2023, 12:54 AM
kuba updated the diff for D8027: [web] Scrolling to the edited message when it overflows.

Respond to the review

Jun 14 2023, 12:48 AM

Jun 12 2023

kuba accepted D8098: [native] Block TimeStamp from rendering in the pinned messages screen.
Jun 12 2023, 6:35 AM
kuba accepted D8099: [native] Force the tooltip to the bottom of the pinned messages screen.
Jun 12 2023, 6:32 AM

Jun 2 2023

kuba updated the diff for D8035: [web][fix] Fixed cursor issue in the message editing.

Add comment

Jun 2 2023, 2:57 AM
kuba accepted D8053: [web] Escape focus trap when an outside node is clicked.
Jun 2 2023, 2:50 AM

Jun 1 2023

kuba added inline comments to D8027: [web] Scrolling to the edited message when it overflows.
Jun 1 2023, 5:58 AM
kuba planned changes to D5463: [web] Call searchUsers in chat composer.
Jun 1 2023, 5:50 AM
kuba updated the diff for D5463: [web] Call searchUsers in chat composer.

Rebase

Jun 1 2023, 3:45 AM
kuba added inline comments to D8035: [web][fix] Fixed cursor issue in the message editing.
Jun 1 2023, 2:53 AM

May 31 2023

kuba added inline comments to D8035: [web][fix] Fixed cursor issue in the message editing.
May 31 2023, 6:52 AM
kuba requested review of D8036: [native] Unify alert behavior when changing selected edited message.
May 31 2023, 2:51 AM
kuba requested review of D8035: [web][fix] Fixed cursor issue in the message editing.
May 31 2023, 12:58 AM

May 30 2023

kuba updated the test plan for D8027: [web] Scrolling to the edited message when it overflows.
May 30 2023, 5:10 AM
kuba requested review of D8027: [web] Scrolling to the edited message when it overflows.
May 30 2023, 5:03 AM

May 25 2023

kuba updated the diff for D7971: [web] Disabled edit button if edited message is empty.

Shorthand

May 25 2023, 4:37 AM
kuba requested review of D7971: [web] Disabled edit button if edited message is empty.
May 25 2023, 2:36 AM
kuba requested review of D7970: [web] Change edit icon to filled.
May 25 2023, 2:00 AM
kuba updated the diff for D7960: [web][fixed] Added FocusTrap for modals.

Memoize param

May 25 2023, 1:30 AM

May 24 2023

kuba requested review of D7960: [web][fixed] Added FocusTrap for modals.
May 24 2023, 10:14 AM
kuba added 1 blocking reviewer(s) for D7837: [web] Added FocusTrap for modals: michal.
May 24 2023, 2:39 AM
kuba updated the diff for D7930: [web] Changed edit modal overlay opacity.

Shorthand

May 24 2023, 2:32 AM

May 23 2023

kuba abandoned D7838: [web] Disabled auto focus on overlay when entering edit mode.
In D7838#235423, @inka wrote:

Why do we want to do that?

May 23 2023, 9:16 AM