[native] Force the tooltip to the bottom of the pinned messages screen
ClosedPublic
Actions

Authored by rohan on Jun 6 2023, 2:46 AM.

Details

Reviewers

• kuba
ginsu

Commits

rCOMM6daf1e11c92f: [native] Force the tooltip to the bottom of the pinned messages screen

Summary

Fixes the second part of ENG-3959, where the tooltip was weirdly placed and reactions were cut off.

Depends on D8098

Test Plan

See the updated video and screenshot below

Simulator Screen Shot - iPhone 14 Pro - 2023-06-05 at 22.47.49.png (2×1 px, 175 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Jun 6 2023, 2:46 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 6 2023, 2:46 AM

rohan edited the summary of this revision. (Show Details)Jun 6 2023, 2:49 AM

rohan edited the test plan for this revision. (Show Details)

rohan added a parent revision: D8098: [native] Block TimeStamp from rendering in the pinned messages screen.

rohan attached a referenced file: F572809: Simulator Screen Recording - iPhone 14 Pro - 2023-06-05 at 22.40.01.mp4. (Show Details)

rohan attached a referenced file: F572817: Simulator Screen Shot - iPhone 14 Pro - 2023-06-05 at 22.47.49.png. (Show Details)

rohan edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B20030: Diff 27450.Jun 6 2023, 3:04 AM

rohan requested review of this revision.Jun 6 2023, 3:04 AM

ginsu accepted this revision.Jun 6 2023, 3:09 PM

• kuba accepted this revision.Jun 12 2023, 1:32 PM

This revision is now accepted and ready to land.Jun 12 2023, 1:32 PM

Closed by commit rCOMM6daf1e11c92f: [native] Force the tooltip to the bottom of the pinned messages screen. · Explain WhyJun 12 2023, 4:55 PM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM6daf1e11c92f: [native] Force the tooltip to the bottom of the pinned messages screen.

Revision Contents
Changeset List

Path

Size

native/

chat/

message-results-screen.react.js

14 lines

Diff 27660

View Options

native/chat/message-results-screen.react.js

[native] Force the tooltip to the bottom of the pinned messages screenClosedPublicActions