Page MenuHomePhabricator
Differential D8099

[native] Force the tooltip to the bottom of the pinned messages screen
ClosedPublic
Actions

Authored by rohan on Jun 5 2023, 7:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 10:30 AM
Unknown Object (File)
Mon, Nov 4, 4:02 PM
Unknown Object (File)
Fri, Nov 1, 7:45 PM
Unknown Object (File)
Mon, Oct 28, 12:37 PM
Unknown Object (File)
Sep 29 2024, 8:41 AM
Unknown Object (File)
Sep 29 2024, 8:41 AM
Unknown Object (File)
Sep 29 2024, 8:41 AM
Unknown Object (File)
Sep 29 2024, 8:40 AM
View All 61 Files
Subscribers
ashoat
tomek

Details

Reviewers
• kuba
ginsu
Commits
rCOMM6daf1e11c92f: [native] Force the tooltip to the bottom of the pinned messages screen
Summary

Fixes the second part of ENG-3959, where the tooltip was weirdly placed and reactions were cut off.

Depends on D8098

Test Plan

See the updated video and screenshot below

Simulator Screen Shot - iPhone 14 Pro - 2023-06-05 at 22.47.49.png (2×1 px, 175 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan created this revision.Jun 5 2023, 7:46 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 5 2023, 7:46 PM
rohan edited the summary of this revision. (Show Details)Jun 5 2023, 7:49 PM
rohan edited the test plan for this revision. (Show Details)
rohan added a parent revision: D8098: [native] Block TimeStamp from rendering in the pinned messages screen.
rohan attached a referenced file: F572809: Simulator Screen Recording - iPhone 14 Pro - 2023-06-05 at 22.40.01.mp4. (Show Details)
rohan attached a referenced file: F572817: Simulator Screen Shot - iPhone 14 Pro - 2023-06-05 at 22.47.49.png. (Show Details)
rohan edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B20030: Diff 27450.Jun 5 2023, 8:04 PM
rohan requested review of this revision.Jun 5 2023, 8:04 PM
ginsu accepted this revision.Jun 6 2023, 8:09 AM
• kuba accepted this revision.Jun 12 2023, 6:32 AM
This revision is now accepted and ready to land.Jun 12 2023, 6:32 AM
Closed by commit rCOMM6daf1e11c92f: [native] Force the tooltip to the bottom of the pinned messages screen (authored by rohan). · Explain WhyJun 12 2023, 9:55 AM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM6daf1e11c92f: [native] Force the tooltip to the bottom of the pinned messages screen.

Revision Contents
Changeset List

PathSize
native/
chat/
14 lines

Diff 27660

View Options

native/chat/message-results-screen.react.js

Loading...