We want to use search users in chat composer so can create chat with users not in user store
Depends on D8012
Details
Details
- Reviewers
kamil inka - Commits
- rCOMMc28f64bd7632: [web] Use search users in chat composer
Search for users. Check if there are users not in user store. Check if they can be selected properly
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/chat/chat-thread-composer.react.js | ||
|---|---|---|
| 65–87 ↗ | (On Diff #27159) | I think there is a possibility to wrap this in a hook in lib to avoid code duplication with D8010? Or am I missing something? Or at least you can move shared code to a shared function |
| 71–80 ↗ | (On Diff #27159) | Are you sure that debounce is not needed? |
Comment Actions
Removed code duplication (function was introduced in D8010)
| web/chat/chat-thread-composer.react.js | ||
|---|---|---|
| 71–80 ↗ | (On Diff #27159) | Other places are not yet debounced, a task for this already exists: https://linear.app/comm/issue/ENG-1327. |