Page MenuHomePhabricator

[web] Change navInfo.selectedUserList to contains user infos
ClosedPublic

Authored by michal on May 29 2023, 6:52 AM.
Tags
None
Referenced Files
F1440415: D8011.id27741.diff
Thu, Mar 28, 9:53 PM
F1440414: D8011.id27157.diff
Thu, Mar 28, 9:53 PM
F1440351: D8011.id.diff
Thu, Mar 28, 9:52 PM
F1440270: D8011.diff
Thu, Mar 28, 9:43 PM
Unknown Object (File)
Feb 18 2024, 12:08 AM
Unknown Object (File)
Feb 17 2024, 10:20 PM
Unknown Object (File)
Feb 17 2024, 8:55 PM
Unknown Object (File)
Feb 17 2024, 5:28 PM
Subscribers

Details

Summary

The users we get from search users endpoint might not be in the userStore. Because of that this diff changes the navInfo to contain the whole userInfos instead of just ids. When selecting a new user in the chat composer we save user info in the navInfo. During redux state updates we use the previous navInfo as the source of the userInfos in the navInfoFromURL.

Depends on D8009

Test Plan

Try adding and removing users from chat composer. Check if the url and navInfo are updated correctly. Try navigating to chat/thread/new/<non-existant-user-id> and check if it is removed.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable