Page MenuHomePhabricator
Differential D8012

[keyserver] Include initial navInfo selectedUserList
ClosedPublic
Actions

Authored by michal on May 29 2023, 6:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 4, 12:06 AM
Unknown Object (File)
Tue, Apr 1, 9:53 PM
Unknown Object (File)
Tue, Apr 1, 12:38 AM
Unknown Object (File)
Mon, Mar 31, 5:50 PM
Unknown Object (File)
Sat, Mar 29, 8:21 PM
Unknown Object (File)
Thu, Mar 27, 4:30 AM
Unknown Object (File)
Wed, Mar 26, 2:10 PM
Unknown Object (File)
Tue, Mar 18, 9:27 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
kamil
inka
ashoat
Commits
rCOMM1617e44dbb87: [keyserver] Include initial navInfo selectedUserList
Summary

If you navigate directly to an url for chat creation we want to include the mentioned users infos in the nav info.

Depends on D8011

Test Plan

Navigate to /chat/create/<user-not-in-userstore> and /chat/create/<user-in-userstore> and check if they both work correctly

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michal created this revision.May 29 2023, 6:59 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 29 2023, 6:59 AM
michal added a child revision: D8013: [web] Use search users in chat composer.May 29 2023, 7:00 AM
Harbormaster completed remote builds in B19827: Diff 27158.May 29 2023, 7:16 AM
michal requested review of this revision.May 29 2023, 7:16 AM
ashoat accepted this revision.May 29 2023, 7:43 AM
ashoat added inline comments.
keyserver/src/responders/website-responders.js
270 ↗(On Diff #27158)

Can you add a code comment explaining what you're doing here?

313–316 ↗(On Diff #27158)

Why are these being awaited in sequence?

web/url-utils.js
83–85 ↗(On Diff #27158)

Can we update this to be read-only?

This revision is now accepted and ready to land.May 29 2023, 7:43 AM
ashoat added inline comments.May 29 2023, 7:43 AM
keyserver/src/responders/website-responders.js
313–316 ↗(On Diff #27158)

Sorry, ignore this comment

michal updated this revision to Diff 27394.Jun 2 2023, 5:38 AM

Comment and readonly

Harbormaster completed remote builds in B19983: Diff 27394.Jun 2 2023, 5:54 AM
Closed by commit rCOMM1617e44dbb87: [keyserver] Include initial navInfo selectedUserList (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyJun 14 2023, 6:32 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM1617e44dbb87: [keyserver] Include initial navInfo selectedUserList.

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
2 lines
responders/
82 lines
web/
4 lines
15 lines

Diff 27743

View Options

keyserver/src/fetchers/user-fetchers.js

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines
class RemoveAllMessagesOperation : public MessageStoreOperationBase { class RemoveAllMessagesOperation : public MessageStoreOperationBase {
public: public:
virtual void execute() override { virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessages(); DatabaseManager::getQueryExecutor().removeAllMessages();
DatabaseManager::getQueryExecutor().removeAllMedia(); DatabaseManager::getQueryExecutor().removeAllMedia();
} }
}; };
class ReplaceMessageThreadsOperation : public MessageStoreOperationBase {
public:
ReplaceMessageThreadsOperation(jsi::Runtime &rt, const jsi::Object &payload)
: msg_threads{} {
auto threads = payload.getProperty(rt, "threads").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < threads.size(rt); idx++) {
auto thread = threads.getValueAtIndex(rt, idx).asObject(rt);
auto thread_id = thread.getProperty(rt, "id").asString(rt).utf8(rt);
auto start_reached = std::stoi(
thread.getProperty(rt, "start_reached").asString(rt).utf8(rt));
auto last_navigated_to = std::stoll(
thread.getProperty(rt, "last_navigated_to").asString(rt).utf8(rt));
auto last_pruned = std::stoll(
thread.getProperty(rt, "last_pruned").asString(rt).utf8(rt));
MessageStoreThread msg_thread = MessageStoreThread{
thread_id, start_reached, last_navigated_to, last_pruned};
this->msg_threads.push_back(msg_thread);
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().replaceMessageStoreThreads(
this->msg_threads);
}
private:
std::vector<MessageStoreThread> msg_threads;
};
class RemoveAllMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessageStoreThreads();
}
};
class RemoveMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
RemoveMessageStoreThreadsOperation(
jsi::Runtime &rt,
const jsi::Object &payload)
: thread_ids{} {
auto payload_ids = payload.getProperty(rt, "ids").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < payload_ids.size(rt); idx++) {
this->thread_ids.push_back(
payload_ids.getValueAtIndex(rt, idx).asString(rt).utf8(rt));
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeMessageStoreThreads(
this->thread_ids);
}
private:
std::vector<std::string> thread_ids;
};
} // namespace comm } // namespace comm
View Options

keyserver/src/responders/website-responders.js

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines
class RemoveAllMessagesOperation : public MessageStoreOperationBase { class RemoveAllMessagesOperation : public MessageStoreOperationBase {
public: public:
virtual void execute() override { virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessages(); DatabaseManager::getQueryExecutor().removeAllMessages();
DatabaseManager::getQueryExecutor().removeAllMedia(); DatabaseManager::getQueryExecutor().removeAllMedia();
} }
}; };
class ReplaceMessageThreadsOperation : public MessageStoreOperationBase {
public:
ReplaceMessageThreadsOperation(jsi::Runtime &rt, const jsi::Object &payload)
: msg_threads{} {
auto threads = payload.getProperty(rt, "threads").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < threads.size(rt); idx++) {
auto thread = threads.getValueAtIndex(rt, idx).asObject(rt);
auto thread_id = thread.getProperty(rt, "id").asString(rt).utf8(rt);
auto start_reached = std::stoi(
thread.getProperty(rt, "start_reached").asString(rt).utf8(rt));
auto last_navigated_to = std::stoll(
thread.getProperty(rt, "last_navigated_to").asString(rt).utf8(rt));
auto last_pruned = std::stoll(
thread.getProperty(rt, "last_pruned").asString(rt).utf8(rt));
MessageStoreThread msg_thread = MessageStoreThread{
thread_id, start_reached, last_navigated_to, last_pruned};
this->msg_threads.push_back(msg_thread);
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().replaceMessageStoreThreads(
this->msg_threads);
}
private:
std::vector<MessageStoreThread> msg_threads;
};
class RemoveAllMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessageStoreThreads();
}
};
class RemoveMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
RemoveMessageStoreThreadsOperation(
jsi::Runtime &rt,
const jsi::Object &payload)
: thread_ids{} {
auto payload_ids = payload.getProperty(rt, "ids").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < payload_ids.size(rt); idx++) {
this->thread_ids.push_back(
payload_ids.getValueAtIndex(rt, idx).asString(rt).utf8(rt));
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeMessageStoreThreads(
this->thread_ids);
}
private:
std::vector<std::string> thread_ids;
};
} // namespace comm } // namespace comm
View Options

web/app.react.js

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines
class RemoveAllMessagesOperation : public MessageStoreOperationBase { class RemoveAllMessagesOperation : public MessageStoreOperationBase {
public: public:
virtual void execute() override { virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessages(); DatabaseManager::getQueryExecutor().removeAllMessages();
DatabaseManager::getQueryExecutor().removeAllMedia(); DatabaseManager::getQueryExecutor().removeAllMedia();
} }
}; };
class ReplaceMessageThreadsOperation : public MessageStoreOperationBase {
public:
ReplaceMessageThreadsOperation(jsi::Runtime &rt, const jsi::Object &payload)
: msg_threads{} {
auto threads = payload.getProperty(rt, "threads").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < threads.size(rt); idx++) {
auto thread = threads.getValueAtIndex(rt, idx).asObject(rt);
auto thread_id = thread.getProperty(rt, "id").asString(rt).utf8(rt);
auto start_reached = std::stoi(
thread.getProperty(rt, "start_reached").asString(rt).utf8(rt));
auto last_navigated_to = std::stoll(
thread.getProperty(rt, "last_navigated_to").asString(rt).utf8(rt));
auto last_pruned = std::stoll(
thread.getProperty(rt, "last_pruned").asString(rt).utf8(rt));
MessageStoreThread msg_thread = MessageStoreThread{
thread_id, start_reached, last_navigated_to, last_pruned};
this->msg_threads.push_back(msg_thread);
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().replaceMessageStoreThreads(
this->msg_threads);
}
private:
std::vector<MessageStoreThread> msg_threads;
};
class RemoveAllMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessageStoreThreads();
}
};
class RemoveMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
RemoveMessageStoreThreadsOperation(
jsi::Runtime &rt,
const jsi::Object &payload)
: thread_ids{} {
auto payload_ids = payload.getProperty(rt, "ids").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < payload_ids.size(rt); idx++) {
this->thread_ids.push_back(
payload_ids.getValueAtIndex(rt, idx).asString(rt).utf8(rt));
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeMessageStoreThreads(
this->thread_ids);
}
private:
std::vector<std::string> thread_ids;
};
} // namespace comm } // namespace comm
View Options

web/url-utils.js

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines
class RemoveAllMessagesOperation : public MessageStoreOperationBase { class RemoveAllMessagesOperation : public MessageStoreOperationBase {
public: public:
virtual void execute() override { virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessages(); DatabaseManager::getQueryExecutor().removeAllMessages();
DatabaseManager::getQueryExecutor().removeAllMedia(); DatabaseManager::getQueryExecutor().removeAllMedia();
} }
}; };
class ReplaceMessageThreadsOperation : public MessageStoreOperationBase {
public:
ReplaceMessageThreadsOperation(jsi::Runtime &rt, const jsi::Object &payload)
: msg_threads{} {
auto threads = payload.getProperty(rt, "threads").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < threads.size(rt); idx++) {
auto thread = threads.getValueAtIndex(rt, idx).asObject(rt);
auto thread_id = thread.getProperty(rt, "id").asString(rt).utf8(rt);
auto start_reached = std::stoi(
thread.getProperty(rt, "start_reached").asString(rt).utf8(rt));
auto last_navigated_to = std::stoll(
thread.getProperty(rt, "last_navigated_to").asString(rt).utf8(rt));
auto last_pruned = std::stoll(
thread.getProperty(rt, "last_pruned").asString(rt).utf8(rt));
MessageStoreThread msg_thread = MessageStoreThread{
thread_id, start_reached, last_navigated_to, last_pruned};
this->msg_threads.push_back(msg_thread);
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().replaceMessageStoreThreads(
this->msg_threads);
}
private:
std::vector<MessageStoreThread> msg_threads;
};
class RemoveAllMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessageStoreThreads();
}
};
class RemoveMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
RemoveMessageStoreThreadsOperation(
jsi::Runtime &rt,
const jsi::Object &payload)
: thread_ids{} {
auto payload_ids = payload.getProperty(rt, "ids").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < payload_ids.size(rt); idx++) {
this->thread_ids.push_back(
payload_ids.getValueAtIndex(rt, idx).asString(rt).utf8(rt));
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeMessageStoreThreads(
this->thread_ids);
}
private:
std::vector<std::string> thread_ids;
};
} // namespace comm } // namespace comm