Paths

Table of Contentst

Differential D8012

[keyserver] Include initial navInfo selectedUserList
ClosedPublic
Actions

Authored by michal on May 29 2023, 6:59 AM.

Tags

None

Referenced Files

	F1677936: D8012.id27743.diff
	Mon, Apr 29, 7:37 AM

	F1677935: D8012.id27394.diff
	Mon, Apr 29, 7:37 AM

	F1677934: D8012.id27158.diff
	Mon, Apr 29, 7:37 AM

	F1677877: D8012.id.diff
	Mon, Apr 29, 7:33 AM

	F1677788: D8012.diff
	Mon, Apr 29, 7:00 AM

	Unknown Object (File)
	Mar 28 2024, 9:53 PM

	Unknown Object (File)
	Mar 28 2024, 9:53 PM

	Unknown Object (File)
	Mar 28 2024, 9:53 PM

View All 36 Files

Subscribers

Details

Reviewers

kamil
inka
ashoat

Commits

rCOMM1617e44dbb87: [keyserver] Include initial navInfo selectedUserList

Summary

If you navigate directly to an url for chat creation we want to include the mentioned users infos in the nav info.

Depends on D8011

Test Plan

Navigate to /chat/create/<user-not-in-userstore> and /chat/create/<user-in-userstore> and check if they both work correctly

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.May 29 2023, 6:59 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 29 2023, 6:59 AM

michal added a child revision: D8013: [web] Use search users in chat composer.May 29 2023, 7:00 AM

Harbormaster completed remote builds in B19827: Diff 27158.May 29 2023, 7:16 AM

michal requested review of this revision.May 29 2023, 7:16 AM

ashoat accepted this revision.May 29 2023, 7:43 AM

ashoat added inline comments.

keyserver/src/responders/website-responders.js
270 ↗	(On Diff #27158)	Can you add a code comment explaining what you're doing here?
313–316 ↗	(On Diff #27158)	Why are these being `await`ed in sequence?
web/url-utils.js
83–85 ↗	(On Diff #27158)	Can we update this to be read-only?

This revision is now accepted and ready to land.May 29 2023, 7:43 AM

ashoat added inline comments.May 29 2023, 7:43 AM

keyserver/src/responders/website-responders.js
313–316 ↗	(On Diff #27158)	Sorry, ignore this comment

Comment and readonly

Harbormaster completed remote builds in B19983: Diff 27394.Jun 2 2023, 5:54 AM

Closed by commit rCOMM1617e44dbb87: [keyserver] Include initial navInfo selectedUserList (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyJun 14 2023, 6:32 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM1617e44dbb87: [keyserver] Include initial navInfo selectedUserList.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

user-fetchers.js

2 lines

responders/

website-responders.js

82 lines

web/

4 lines

15 lines

Diff 27743

keyserver/src/fetchers/user-fetchers.js

Loading...

keyserver/src/responders/website-responders.js

Loading...

web/app.react.js

Loading...

web/url-utils.js

Loading...