Page MenuHomePhabricator
Differential D7838

[web] Disabled auto focus on overlay when entering edit mode
AbandonedPublic
Actions

Authored by • kuba on May 16 2023, 5:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 5:23 PM
Unknown Object (File)
Wed, Mar 12, 6:48 AM
Unknown Object (File)
Thu, Mar 6, 9:26 PM
Unknown Object (File)
Tue, Mar 4, 8:23 AM
Unknown Object (File)
Tue, Mar 4, 8:23 AM
Unknown Object (File)
Tue, Mar 4, 8:22 AM
Unknown Object (File)
Tue, Mar 4, 8:15 AM
Unknown Object (File)
Thu, Feb 27, 7:51 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
inka
Summary

We want to focus in the textarea instead of the modal. I disabled auto focusing on modal, when the modal is used for editing message.

Test Plan

Checked if after entering edit mode the focus is set to the textarea.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
components/
7 lines
web/
chat/
6 lines

Diff 26646

View Options

lib/components/modal-overlay.react.js

use clap::{Parser, Subcommand}; use clap::{Parser, Subcommand};
use database::DatabaseClient;
use rusoto_core::Region;
use tonic::transport::Server; use tonic::transport::Server;
use tracing_subscriber::FmtSubscriber; use tracing_subscriber::FmtSubscriber;
mod config; mod config;
mod database;
mod keygen; mod keygen;
mod opaque; mod opaque;
mod service; mod service;
use config::Config; use config::Config;
use keygen::generate_and_persist_keypair; use keygen::generate_and_persist_keypair;
use service::{IdentityServiceServer, MyIdentityService}; use service::{IdentityServiceServer, MyIdentityService};
Show All 27 Linesasync fn main() -> Result<(), Box<dyn std::error::Error>> {
let cli = Cli::parse(); let cli = Cli::parse();
match &cli.command { match &cli.command {
Commands::Keygen { dir } => { Commands::Keygen { dir } => {
generate_and_persist_keypair(dir)?; generate_and_persist_keypair(dir)?;
} }
Commands::Server => { Commands::Server => {
let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?; let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?;
let config = Config::load()?; let config = Config::load()?;
let identity_service = MyIdentityService::new(config); let database_client = DatabaseClient::new(Region::UsEast2);
let identity_service = MyIdentityService::new(config, database_client);
Server::builder() Server::builder()
.add_service(IdentityServiceServer::new(identity_service)) .add_service(IdentityServiceServer::new(identity_service))
.serve(addr) .serve(addr)
.await?; .await?;
} }
} }
Ok(()) Ok(())
} }
View Options

web/chat/edit-message-provider.js

use clap::{Parser, Subcommand}; use clap::{Parser, Subcommand};
use database::DatabaseClient;
use rusoto_core::Region;
use tonic::transport::Server; use tonic::transport::Server;
use tracing_subscriber::FmtSubscriber; use tracing_subscriber::FmtSubscriber;
mod config; mod config;
mod database;
mod keygen; mod keygen;
mod opaque; mod opaque;
mod service; mod service;
use config::Config; use config::Config;
use keygen::generate_and_persist_keypair; use keygen::generate_and_persist_keypair;
use service::{IdentityServiceServer, MyIdentityService}; use service::{IdentityServiceServer, MyIdentityService};
Show All 27 Linesasync fn main() -> Result<(), Box<dyn std::error::Error>> {
let cli = Cli::parse(); let cli = Cli::parse();
match &cli.command { match &cli.command {
Commands::Keygen { dir } => { Commands::Keygen { dir } => {
generate_and_persist_keypair(dir)?; generate_and_persist_keypair(dir)?;
} }
Commands::Server => { Commands::Server => {
let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?; let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?;
let config = Config::load()?; let config = Config::load()?;
let identity_service = MyIdentityService::new(config); let database_client = DatabaseClient::new(Region::UsEast2);
let identity_service = MyIdentityService::new(config, database_client);
Server::builder() Server::builder()
.add_service(IdentityServiceServer::new(identity_service)) .add_service(IdentityServiceServer::new(identity_service))
.serve(addr) .serve(addr)
.await?; .await?;
} }
} }
Ok(()) Ok(())
} }