Paths

Table of Contentst

Differential D7833

[web] Storing edited message component position
ClosedPublic
Actions

Authored by • kuba on May 16 2023, 4:20 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 11, 7:55 PM

	Unknown Object (File)
	Sun, Dec 8, 6:43 PM

	Unknown Object (File)
	Sun, Dec 8, 6:43 PM

	Unknown Object (File)
	Wed, Dec 4, 4:05 AM

	Unknown Object (File)
	Wed, Dec 4, 4:05 AM

	Unknown Object (File)
	Wed, Dec 4, 4:04 AM

	Unknown Object (File)
	Sat, Nov 30, 4:07 AM

	Unknown Object (File)
	Tue, Nov 26, 10:51 PM

Subscribers

Details

Reviewers

michal
inka

Commits

rCOMM58104dbd1675: [web] Storing edited message component position

Summary

To display a modal of the editing message GUI, I have to store and update the current position of the edited message.

Test Plan

Checked if the position is correctly stored after entering edit mode.
Resized the window, checked if the position is updated.
Added/removed few lines to the message, checked if the position is updated.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• kuba created this revision.May 16 2023, 4:20 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 16 2023, 4:20 AM

• kuba added a parent revision: D7830: [web] Added setting `Edit failed` state.May 16 2023, 4:21 AM

Harbormaster completed remote builds in B19384: Diff 26519.May 16 2023, 4:37 AM

• kuba requested review of this revision.May 16 2023, 4:37 AM

• kuba added a child revision: D7836: [web] Displaying modal of editing message GUI.May 16 2023, 5:40 AM

Rebase

Harbormaster completed remote builds in B19478: Diff 26643.May 18 2023, 8:32 AM

michal added inline comments.May 19 2023, 3:01 AM

web/chat/chat-input-text-area.react.js
15 ↗	(On Diff #26643)	Why is this typed as `any`?
web/chat/edit-message-provider.js
93–95 ↗	(On Diff #26643)	Can this happen? Should this be an invariant?
web/chat/edit-text-message.react.js
91 ↗	(On Diff #26643)	This is needed because of eslint?

ashoat added inline comments.May 19 2023, 6:20 AM

web/chat/chat-input-text-area.react.js
15 ↗	(On Diff #26643)	Should not use `any`
web/chat/edit-text-message.react.js
89 ↗	(On Diff #26643)	Nit: we usually do `React.useEffect` here
91 ↗	(On Diff #26643)	Should be possible to `return undefined`

Address review

Harbormaster completed remote builds in B19637: Diff 26845.May 23 2023, 1:52 AM

michal accepted this revision.May 23 2023, 4:29 AM

This revision is now accepted and ready to land.May 23 2023, 4:29 AM

ashoat added inline comments.May 23 2023, 7:01 AM

web/chat/chat-input-text-area.react.js
9–14 ↗	(On Diff #26845)	It never hurts to be flexible with props (and with input parameters). If we don't care about the return, we do not need to insist on the function returning `void`. It can return anything, and it won't matter to us

Closed by commit rCOMM58104dbd1675: [web] Storing edited message component position (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyMay 24 2023, 3:47 AM

This revision was automatically updated to reflect the committed changes.

kosmydel <kukubaczek@gmail.com> added a commit: rCOMM58104dbd1675: [web] Storing edited message component position.

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-input-text-area.react.js

13 lines

edit-message-provider.js

32 lines

edit-text-message.react.js

36 lines

Diff 26951

web/chat/chat-input-text-area.react.js

Loading...

web/chat/edit-message-provider.js

Loading...

web/chat/edit-text-message.react.js

Loading...