Page MenuHomePhabricator
Differential D7828

[web] Added message editing
ClosedPublic
Actions

Authored by • kuba on May 16 2023, 3:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 2:23 AM
Unknown Object (File)
Wed, Dec 4, 4:04 AM
Unknown Object (File)
Wed, Dec 4, 4:04 AM
Unknown Object (File)
Wed, Dec 4, 4:04 AM
Unknown Object (File)
Tue, Dec 3, 10:52 PM
Unknown Object (File)
Tue, Dec 3, 10:52 PM
Unknown Object (File)
Tue, Dec 3, 10:51 PM
Unknown Object (File)
Tue, Dec 3, 10:51 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
inka
Commits
rCOMMd1b6e4104c42: [web] Added message editing
Summary

Added message editing after the user clicks Save or presses Enter.

Test Plan
  • selected message to edit, made changes, pressed Save -> the message was successfully edited,
  • selected message to edit, pressed save without edits -> exited edit mode without sending edit message

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• kuba created this revision.May 16 2023, 3:57 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 16 2023, 3:57 AM
• kuba added a parent revision: D7827: [web] Display edit state (in the background).May 16 2023, 3:58 AM
• kuba updated this revision to Diff 26512.May 16 2023, 4:08 AM

Renamed function

• kuba added a child revision: D7830: [web] Added setting `Edit failed` state.May 16 2023, 4:10 AM
Harbormaster completed remote builds in B19375: Diff 26510.May 16 2023, 4:15 AM
Harbormaster completed remote builds in B19377: Diff 26512.May 16 2023, 4:26 AM
• kuba requested review of this revision.May 16 2023, 4:26 AM
• kuba updated this revision to Diff 26630.May 18 2023, 5:40 AM

Added setting error state, merged with next diff

• kuba mentioned this in D7830: [web] Added setting `Edit failed` state.May 18 2023, 5:40 AM
Harbormaster completed remote builds in B19465: Diff 26630.May 18 2023, 5:59 AM
• kuba updated this revision to Diff 26642.May 18 2023, 8:11 AM

Rebase

Harbormaster completed remote builds in B19477: Diff 26642.May 18 2023, 8:30 AM
michal accepted this revision.May 19 2023, 2:55 AM
michal added inline comments.
web/chat/edit-message-provider.js
70–72 ↗(On Diff #26642)

Is this possible? Should we use an invariant?

web/chat/edit-text-message.react.js
62–64 ↗(On Diff #26642)

In this case we probably want to clearEditModal?

This revision is now accepted and ready to land.May 19 2023, 2:55 AM
• kuba marked 2 inline comments as done.May 22 2023, 5:10 AM
• kuba added inline comments.
web/chat/edit-message-provider.js
70–72 ↗(On Diff #26642)

You are right. We use it only inside the edit modal. We can probably use here invariant.

web/chat/edit-text-message.react.js
62–64 ↗(On Diff #26642)

It is here to prevent typing warnings. If the user leaves an empty message and wants to save it, we clear the edit modal (lines 50 and 59) anyway. Probably, I could use here an invariant as well. Should I change it?

• kuba updated this revision to Diff 26762.May 22 2023, 5:10 AM
• kuba marked 2 inline comments as done.

Added invariant

Harbormaster completed remote builds in B19579: Diff 26762.May 22 2023, 5:29 AM
Closed by commit rCOMMd1b6e4104c42: [web] Added message editing (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyMay 24 2023, 3:47 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <kukubaczek@gmail.com> added a commit: rCOMMd1b6e4104c42: [web] Added message editing.

Revision Contents
Changeset List

Diff 26950

View Options

web/chat/edit-message-provider.js

Loading...
View Options

web/chat/edit-text-message.react.js

Loading...