Page MenuHomePhabricator

[web] Display edit state (in the background)
ClosedPublic

Authored by kuba on May 16 2023, 3:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 22, 4:37 PM
Unknown Object (File)
Wed, Jun 19, 6:50 PM
Unknown Object (File)
Sat, Jun 15, 7:55 AM
Unknown Object (File)
Sat, Jun 15, 12:29 AM
Unknown Object (File)
Thu, Jun 13, 5:40 PM
Unknown Object (File)
Thu, Jun 13, 4:55 PM
Unknown Object (File)
Thu, Jun 6, 10:52 PM
Unknown Object (File)
Thu, Jun 6, 2:47 PM
Subscribers

Details

Summary

Display the edit message component.

Later I will add a modal, which covers the screen, to prevent the user from navigating outside the thread. This one is to move other messages in chats accordingly to the height of this component.

Test Plan

Run the app. Press the edit button. It shows the new component. Pressed cancel in the new component. It left edit state.

Screenshot:

Screenshot 2023-05-16 at 12.52.27.png (784×1 px, 69 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kuba edited the test plan for this revision. (Show Details)
kuba edited the summary of this revision. (Show Details)
kuba added inline comments.
web/chat/message.react.js
46 ↗(On Diff #26506)

It tells the component that this copy of it is a "background" one. It will be used later, to determine which component (modal or background one) should be focused.

michal added inline comments.
web/chat/message.react.js
47 ↗(On Diff #26506)

Where is this number from?

This revision is now accepted and ready to land.May 18 2023, 4:16 AM

Removed width from the EditTextMessage

web/chat/message.react.js
47 ↗(On Diff #26506)

It is removed after changes.

web/chat/message.react.js
43–47 ↗(On Diff #26841)
kuba marked an inline comment as done.

Review