Differential D7970

[web] Change edit icon to filled
ClosedPublic
Actions

Authored by • kuba on May 25 2023, 1:41 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Mar 23, 6:14 AM

	Unknown Object (File)
	Thu, Mar 20, 11:09 PM

	Unknown Object (File)
	Mar 5 2025, 12:59 PM

	Unknown Object (File)
	Feb 24 2025, 8:04 PM

	Unknown Object (File)
	Feb 24 2025, 3:01 PM

	Unknown Object (File)
	Feb 24 2025, 3:01 PM

	Unknown Object (File)
	Feb 24 2025, 3:01 PM

	Unknown Object (File)
	Feb 21 2025, 1:33 AM

Subscribers

Details

Reviewers

michal
inka

Commits

rCOMM598de93c1c30: [web] Change edit icon to filled

Summary

Changed edit icon to filled one, to match other icons.

Test Plan

Checked if the icons in the tooltip match.

Screenshot 2023-05-25 at 10.41.06.png (280×688 px, 29 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• kuba created this revision.May 25 2023, 1:41 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 25 2023, 1:41 AM

• kuba edited the summary of this revision. (Show Details)May 25 2023, 1:42 AM

• kuba edited the test plan for this revision. (Show Details)

• kuba attached a referenced file: F558215: Screenshot 2023-05-25 at 10.41.06.png. (Show Details)

Harbormaster completed remote builds in B19759: Diff 27040.May 25 2023, 2:00 AM

• kuba requested review of this revision.May 25 2023, 2:00 AM

michal accepted this revision.May 25 2023, 2:02 AM

This revision is now accepted and ready to land.May 25 2023, 2:02 AM

Closed by commit rCOMM598de93c1c30: [web] Change edit icon to filled (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyMay 25 2023, 2:06 AM

This revision was automatically updated to reflect the committed changes.

kosmydel <kukubaczek@gmail.com> added a commit: rCOMM598de93c1c30: [web] Change edit icon to filled.

Revision Contents
Changeset List

Path

Size

web/

CommIcon.react.js

3 lines

utils/

tooltip-action-utils.js

5 lines

Diff 27041

web/CommIcon.react.js

	div.headerContainer {			div.loginContainer {
	flex: 1 1 auto;
	padding: 0 10px;
	}
	div.headerContents {
	display: flex;			display: flex;
	justify-content: space-between;			justify-content: center;
	align-items: center;
	padding-top: 5px;
	padding-bottom: 7px;
	}
	div.actionLinks > * {
	padding-right: 15px;
	color: white;
	font-weight: 300;
	}
	div.actionLinks > *:last-child {
	padding-right: 0;
	}
	header.header h1 {
	color: white;			color: white;
	font-size: 38px;
	}
	header.header {
	padding: 10px 20px;
	border-radius: 20px;
	border: 1px solid white;
	}			}

web/utils/tooltip-action-utils.js

	div.headerContainer {			div.loginContainer {
	flex: 1 1 auto;
	padding: 0 10px;
	}
	div.headerContents {
	display: flex;			display: flex;
	justify-content: space-between;			justify-content: center;
	align-items: center;
	padding-top: 5px;
	padding-bottom: 7px;
	}
	div.actionLinks > * {
	padding-right: 15px;
	color: white;
	font-weight: 300;
	}
	div.actionLinks > *:last-child {
	padding-right: 0;
	}
	header.header h1 {
	color: white;			color: white;
	font-size: 38px;
	}
	header.header {
	padding: 10px 20px;
	border-radius: 20px;
	border: 1px solid white;
	}			}