Page MenuHomePhabricator
Differential D7970

[web] Change edit icon to filled
ClosedPublic
Actions

Authored by • kuba on May 25 2023, 1:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 3:25 AM
Unknown Object (File)
Sun, Apr 20, 2:44 AM
Unknown Object (File)
Sun, Apr 20, 1:44 AM
Unknown Object (File)
Sat, Apr 19, 3:48 AM
Unknown Object (File)
Mar 23 2025, 6:14 AM
Unknown Object (File)
Mar 20 2025, 11:09 PM
Unknown Object (File)
Mar 5 2025, 12:59 PM
Unknown Object (File)
Feb 24 2025, 8:04 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
michal
inka
Commits
rCOMM598de93c1c30: [web] Change edit icon to filled
Summary

Changed edit icon to filled one, to match other icons.

Test Plan

Checked if the icons in the tooltip match.

Screenshot 2023-05-25 at 10.41.06.png (280×688 px, 29 KB)

Diff Detail

Repository
rCOMM Comm
Branch
kuba/empty_messages_web
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
3 lines
utils/
5 lines

Diff 27040

View Options

web/CommIcon.react.js

Show First 20 Lines • Show All 101 Lines • ▼ Show 20 Lines const [alchemySecret, walletConnectSecret] = await Promise.all([
getConfig({ folder: 'secrets', name: 'alchemy' }), getConfig({ folder: 'secrets', name: 'alchemy' }),
getConfig({ folder: 'secrets', name: 'walletconnect' }), getConfig({ folder: 'secrets', name: 'walletconnect' }),
]); ]);
const alchemyKey = alchemySecret?.key; const alchemyKey = alchemySecret?.key;
const walletConnectKey = walletConnectSecret?.key; const walletConnectKey = walletConnectSecret?.key;
return { alchemyKey, walletConnectKey }; return { alchemyKey, walletConnectKey };
} }
async function createProdBrowserConfig(baseConfig, babelConfig) { async function createProdBrowserConfig(baseConfig, babelConfig, envVars) {
const browserConfig = createBaseBrowserConfig(baseConfig); const browserConfig = createBaseBrowserConfig(baseConfig);
const babelRule = getBrowserBabelRule(babelConfig); const babelRule = getBrowserBabelRule(babelConfig);
const { alchemyKey, walletConnectKey } = await getConfigs(); const { alchemyKey, walletConnectKey } = await getConfigs();
return { return {
...browserConfig, ...browserConfig,
mode: 'production', mode: 'production',
plugins: [ plugins: [
...browserConfig.plugins, ...browserConfig.plugins,
new webpack.DefinePlugin({ new webpack.DefinePlugin({
'process.env': { 'process.env': {
NODE_ENV: JSON.stringify('production'), NODE_ENV: JSON.stringify('production'),
BROWSER: true, BROWSER: true,
COMM_ALCHEMY_KEY: JSON.stringify(alchemyKey), COMM_ALCHEMY_KEY: JSON.stringify(alchemyKey),
COMM_WALLETCONNECT_KEY: JSON.stringify(walletConnectKey), COMM_WALLETCONNECT_KEY: JSON.stringify(walletConnectKey),
...envVars,
}, },
}), }),
new MiniCssExtractPlugin({ new MiniCssExtractPlugin({
filename: 'prod.[contenthash:12].build.css', filename: 'prod.[contenthash:12].build.css',
}), }),
], ],
module: { module: {
rules: [ rules: [
Show All 37 Lines module: {
}, },
], ],
}, },
], ],
}, },
}; };
} }
async function createDevBrowserConfig(baseConfig, babelConfig) { async function createDevBrowserConfig(baseConfig, babelConfig, envVars) {
const browserConfig = createBaseBrowserConfig(baseConfig); const browserConfig = createBaseBrowserConfig(baseConfig);
const babelRule = getBrowserBabelRule(babelConfig); const babelRule = getBrowserBabelRule(babelConfig);
const { alchemyKey, walletConnectKey } = await getConfigs(); const { alchemyKey, walletConnectKey } = await getConfigs();
return { return {
...browserConfig, ...browserConfig,
mode: 'development', mode: 'development',
plugins: [ plugins: [
...browserConfig.plugins, ...browserConfig.plugins,
new webpack.DefinePlugin({ new webpack.DefinePlugin({
'process.env': { 'process.env': {
NODE_ENV: JSON.stringify('development'), NODE_ENV: JSON.stringify('development'),
BROWSER: true, BROWSER: true,
COMM_ALCHEMY_KEY: JSON.stringify(alchemyKey), COMM_ALCHEMY_KEY: JSON.stringify(alchemyKey),
COMM_WALLETCONNECT_KEY: JSON.stringify(walletConnectKey), COMM_WALLETCONNECT_KEY: JSON.stringify(walletConnectKey),
...envVars,
}, },
}), }),
new ReactRefreshWebpackPlugin(), new ReactRefreshWebpackPlugin(),
], ],
module: { module: {
rules: [ rules: [
{ {
...babelRule, ...babelRule,
▲ Show 20 Lines • Show All 99 Lines • Show Last 20 Lines
View Options

web/utils/tooltip-action-utils.js

Show First 20 Lines • Show All 101 Lines • ▼ Show 20 Lines const [alchemySecret, walletConnectSecret] = await Promise.all([
getConfig({ folder: 'secrets', name: 'alchemy' }), getConfig({ folder: 'secrets', name: 'alchemy' }),
getConfig({ folder: 'secrets', name: 'walletconnect' }), getConfig({ folder: 'secrets', name: 'walletconnect' }),
]); ]);
const alchemyKey = alchemySecret?.key; const alchemyKey = alchemySecret?.key;
const walletConnectKey = walletConnectSecret?.key; const walletConnectKey = walletConnectSecret?.key;
return { alchemyKey, walletConnectKey }; return { alchemyKey, walletConnectKey };
} }
async function createProdBrowserConfig(baseConfig, babelConfig) { async function createProdBrowserConfig(baseConfig, babelConfig, envVars) {
const browserConfig = createBaseBrowserConfig(baseConfig); const browserConfig = createBaseBrowserConfig(baseConfig);
const babelRule = getBrowserBabelRule(babelConfig); const babelRule = getBrowserBabelRule(babelConfig);
const { alchemyKey, walletConnectKey } = await getConfigs(); const { alchemyKey, walletConnectKey } = await getConfigs();
return { return {
...browserConfig, ...browserConfig,
mode: 'production', mode: 'production',
plugins: [ plugins: [
...browserConfig.plugins, ...browserConfig.plugins,
new webpack.DefinePlugin({ new webpack.DefinePlugin({
'process.env': { 'process.env': {
NODE_ENV: JSON.stringify('production'), NODE_ENV: JSON.stringify('production'),
BROWSER: true, BROWSER: true,
COMM_ALCHEMY_KEY: JSON.stringify(alchemyKey), COMM_ALCHEMY_KEY: JSON.stringify(alchemyKey),
COMM_WALLETCONNECT_KEY: JSON.stringify(walletConnectKey), COMM_WALLETCONNECT_KEY: JSON.stringify(walletConnectKey),
...envVars,
}, },
}), }),
new MiniCssExtractPlugin({ new MiniCssExtractPlugin({
filename: 'prod.[contenthash:12].build.css', filename: 'prod.[contenthash:12].build.css',
}), }),
], ],
module: { module: {
rules: [ rules: [
Show All 37 Lines module: {
}, },
], ],
}, },
], ],
}, },
}; };
} }
async function createDevBrowserConfig(baseConfig, babelConfig) { async function createDevBrowserConfig(baseConfig, babelConfig, envVars) {
const browserConfig = createBaseBrowserConfig(baseConfig); const browserConfig = createBaseBrowserConfig(baseConfig);
const babelRule = getBrowserBabelRule(babelConfig); const babelRule = getBrowserBabelRule(babelConfig);
const { alchemyKey, walletConnectKey } = await getConfigs(); const { alchemyKey, walletConnectKey } = await getConfigs();
return { return {
...browserConfig, ...browserConfig,
mode: 'development', mode: 'development',
plugins: [ plugins: [
...browserConfig.plugins, ...browserConfig.plugins,
new webpack.DefinePlugin({ new webpack.DefinePlugin({
'process.env': { 'process.env': {
NODE_ENV: JSON.stringify('development'), NODE_ENV: JSON.stringify('development'),
BROWSER: true, BROWSER: true,
COMM_ALCHEMY_KEY: JSON.stringify(alchemyKey), COMM_ALCHEMY_KEY: JSON.stringify(alchemyKey),
COMM_WALLETCONNECT_KEY: JSON.stringify(walletConnectKey), COMM_WALLETCONNECT_KEY: JSON.stringify(walletConnectKey),
...envVars,
}, },
}), }),
new ReactRefreshWebpackPlugin(), new ReactRefreshWebpackPlugin(),
], ],
module: { module: {
rules: [ rules: [
{ {
...babelRule, ...babelRule,
▲ Show 20 Lines • Show All 99 Lines • Show Last 20 Lines