Page MenuHomePhabricator

[web] Unify behaviour of chat composer with native
ClosedPublic

Authored by kuba on Jun 15 2023, 1:26 AM.
Tags
None
Referenced Files
F1703501: D8224.diff
Sun, May 5, 6:59 AM
Unknown Object (File)
Sat, May 4, 2:40 PM
Unknown Object (File)
Sat, May 4, 2:39 PM
Unknown Object (File)
Mon, Apr 29, 7:34 AM
Unknown Object (File)
Mon, Apr 29, 7:34 AM
Unknown Object (File)
Mon, Apr 29, 7:33 AM
Unknown Object (File)
Mon, Apr 29, 7:01 AM
Unknown Object (File)
Sat, Apr 27, 4:31 AM
Subscribers

Details

Summary

An updated version of https://phab.comm.dev/D5518 (in the new stack). Task: https://linear.app/comm/issue/ENG-4022/[web]-unify-behaviour-of-chat-composer-with-native

The web app should behave as the native app:

  • when selecting someone in the chat composer who isn't a friend, and when nobody else is selected, the web app should exit the search and create a 1-1 thread with this user
  • should display an alert if you try to add a non-friend when you have already selected some users
  • should display an alert on blocked users
Test Plan
  • select a friend, create chat
  • select a non-friend -> search should end and chat should be displayed without the search bar
  • select a friend, than a non-friend -> alert should be displayed
  • select a blocked user -> alert should be displayed

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable