Move 'InlineEngagement' styling from 'ComposedMessage' to 'InlineEngagement' component to make it concise with the web version. It makes it also easier to add message labels to the code, so they were in the 'InlineEngagement' component, like on the web.
Details
Details
Checked if everything works after the changes. Nothing visible should change. Compared how reactions and threads are rendered in iOS and Android simulators with the old
version.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/chat/inline-engagement.react.js | ||
|---|---|---|
| 125–132 ↗ | (On Diff #24070) | Why can't this be inlined in line 146? Is this memo necessary? |
| native/chat/inline-engagement.react.js | ||
|---|---|---|
| 125–132 ↗ | (On Diff #24070) | Here it probably could be inlined. But I prepared it for the next diff: https://phab.comm.dev/D7065 (which still requires some changes, which will partly answer this question). |
| native/chat/inline-engagement.react.js | ||
|---|---|---|
| 125–132 ↗ | (On Diff #24070) | I see, thank you |