Page MenuHomePhabricator

[lib][keyserver] Added new edit_message endpoint
ClosedPublic

Authored by kuba on Mar 21 2023, 11:30 AM.
Tags
None
Referenced Files
F1430399: D7128.id.diff
Wed, Mar 27, 10:24 PM
F1430344: D7128.diff
Wed, Mar 27, 10:11 PM
Unknown Object (File)
Thu, Mar 7, 2:05 PM
Unknown Object (File)
Thu, Mar 7, 1:37 PM
Unknown Object (File)
Thu, Mar 7, 1:10 PM
Unknown Object (File)
Thu, Mar 7, 10:27 AM
Unknown Object (File)
Thu, Mar 7, 5:53 AM
Unknown Object (File)
Thu, Mar 7, 5:53 AM
Subscribers

Details

Summary

Added new editMessageResponder with validation. Registered it as an endpoint.

Test Plan

In later diffs checked if it is possible to communicate with the keyserver. For now, checked if there are no flow errors and if the app is working correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think you test plan got cut off

keyserver/src/responders/message-responders.js
339–350 ↗(On Diff #23977)

Can we simplify this?

keyserver/src/responders/message-responders.js
339–350 ↗(On Diff #23977)

Sure, I could do that here, but the array is still needed in a later diff: https://phab.comm.dev/D7145

What about the test plan?

keyserver/src/responders/message-responders.js
339–350 ↗(On Diff #23977)

Alright, no need then

In D7128#214943, @inka wrote:

What about the test plan?

Sorry, I haven't seen the comment. I've just completed the test plan.

This revision is now accepted and ready to land.Mar 30 2023, 2:54 AM