Page MenuHomePhabricator
Differential D7127

[lib][keyserver] Introduce new threadPermissions types for editing messages
ClosedPublic
Actions

Authored by • kuba on Mar 21 2023, 11:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 7:28 PM
Unknown Object (File)
Mon, Mar 17, 7:28 PM
Unknown Object (File)
Mon, Mar 17, 7:28 PM
Unknown Object (File)
Mon, Mar 17, 7:27 PM
Unknown Object (File)
Mon, Mar 17, 7:10 PM
Unknown Object (File)
Tue, Feb 25, 7:01 AM
Unknown Object (File)
Mon, Feb 24, 4:41 PM
Unknown Object (File)
Mon, Feb 24, 4:41 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ginsu
michal
inka
ashoat
Commits
rCOMM6adb242a4132: [lib][keyserver] Introduce new threadPermissions types for editing messages
Summary

We sometimes would want to block editing messages, but still be able to write new messages to the thread.

This diff introduces the type, adds it to all roles except GENESIS members, and adds a new migration to populate it.

Test Plan

Checked if migration worked. The permissions check will be added with another diff.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• kuba created this revision.Mar 21 2023, 11:22 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 21 2023, 11:22 AM
• kuba added a parent revision: D7066: [native] Displaying 'Edit' labels next to edited messages.Mar 21 2023, 11:22 AM
• kuba added a child revision: D7128: [lib][keyserver] Added new edit_message endpoint.Mar 21 2023, 11:30 AM
Harbormaster completed remote builds in B17486: Diff 23954.Mar 21 2023, 11:37 AM
• kuba requested review of this revision.Mar 21 2023, 11:37 AM
ashoat accepted this revision.Mar 22 2023, 11:46 AM
This revision is now accepted and ready to land.Mar 22 2023, 11:46 AM
• kuba updated this revision to Diff 24209.Mar 27 2023, 8:07 AM

Rebase

Harbormaster completed remote builds in B17686: Diff 24209.Mar 27 2023, 8:23 AM
Closed by commit rCOMM6adb242a4132: [lib][keyserver] Introduce new threadPermissions types for editing messages (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyMar 30 2023, 7:43 AM
This revision was automatically updated to reflect the committed changes.
kosmydel <kukubaczek@gmail.com> added a commit: rCOMM6adb242a4132: [lib][keyserver] Introduce new threadPermissions types for editing messages.
atul mentioned this in D7313: [lib] Introduce `threadPermissions.EDIT_THREAD_AVATAR`.Apr 5 2023, 7:26 AM
atul mentioned this in rCOMMf965bca79f04: [lib] Introduce `threadPermissions.EDIT_THREAD_AVATAR`.Apr 5 2023, 1:01 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
6 lines
database/
1 line
lib/
types/
4 lines

Diff 24411

View Options

keyserver/src/creators/role-creator.js

{ {
"nodes": { "nodes": {
"nixpkgs": { "nixpkgs": {
"locked": { "locked": {
"lastModified": 1651114127, "lastModified": 1655481042,
"narHash": "sha256-/lLC0wkMZkAdA5e1W76SnJzbhfOGDvync3VRHJMtAKk=", "narHash": "sha256-XHbcywq2vIQ5CeH1OK3TN793jkiNAAZsSctS1PFgseo=",
"owner": "nixos", "owner": "nixos",
"repo": "nixpkgs", "repo": "nixpkgs",
"rev": "6766fb6503ae1ebebc2a9704c162b2aef351f921", "rev": "103a4c0ae46afa9cf008c30744175315ca38e9f9",
"type": "github" "type": "github"
}, },
"original": { "original": {
"owner": "nixos", "owner": "nixos",
"ref": "nixpkgs-unstable", "ref": "nixpkgs-unstable",
"repo": "nixpkgs", "repo": "nixpkgs",
"type": "github" "type": "github"
} }
Show All 26 Lines
View Options

keyserver/src/database/migration-config.js

{ {
"nodes": { "nodes": {
"nixpkgs": { "nixpkgs": {
"locked": { "locked": {
"lastModified": 1651114127, "lastModified": 1655481042,
"narHash": "sha256-/lLC0wkMZkAdA5e1W76SnJzbhfOGDvync3VRHJMtAKk=", "narHash": "sha256-XHbcywq2vIQ5CeH1OK3TN793jkiNAAZsSctS1PFgseo=",
"owner": "nixos", "owner": "nixos",
"repo": "nixpkgs", "repo": "nixpkgs",
"rev": "6766fb6503ae1ebebc2a9704c162b2aef351f921", "rev": "103a4c0ae46afa9cf008c30744175315ca38e9f9",
"type": "github" "type": "github"
}, },
"original": { "original": {
"owner": "nixos", "owner": "nixos",
"ref": "nixpkgs-unstable", "ref": "nixpkgs-unstable",
"repo": "nixpkgs", "repo": "nixpkgs",
"type": "github" "type": "github"
} }
Show All 26 Lines
View Options

lib/types/thread-types.js

{ {
"nodes": { "nodes": {
"nixpkgs": { "nixpkgs": {
"locked": { "locked": {
"lastModified": 1651114127, "lastModified": 1655481042,
"narHash": "sha256-/lLC0wkMZkAdA5e1W76SnJzbhfOGDvync3VRHJMtAKk=", "narHash": "sha256-XHbcywq2vIQ5CeH1OK3TN793jkiNAAZsSctS1PFgseo=",
"owner": "nixos", "owner": "nixos",
"repo": "nixpkgs", "repo": "nixpkgs",
"rev": "6766fb6503ae1ebebc2a9704c162b2aef351f921", "rev": "103a4c0ae46afa9cf008c30744175315ca38e9f9",
"type": "github" "type": "github"
}, },
"original": { "original": {
"owner": "nixos", "owner": "nixos",
"ref": "nixpkgs-unstable", "ref": "nixpkgs-unstable",
"repo": "nixpkgs", "repo": "nixpkgs",
"type": "github" "type": "github"
} }
Show All 26 Lines