[keyserver] Adding edit_message to the sidebar thread
ClosedPublic
Actions

Authored by • kuba on Mar 22 2023, 6:24 AM.

Details

Reviewers

michal
inka
ginsu
ashoat

Commits

rCOMM4ccb27a3512b: [keyserver] Adding edit_message to the sidebar thread

Summary

This handles the situation, where the user edits a message which has a sidebar. It adds edit_message to the sidebar thread.

Test Plan

Called editing message endpoint for a message which has a sidebar. The edit message has been added to both the main thread and the sidebar thread. Reducer on client side properly
merges two new messages instead of one.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• kuba created this revision.Mar 22 2023, 6:24 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 22 2023, 6:24 AM

• kuba added a parent revision: D7144: [lib] Added edit message action reducer.Mar 22 2023, 6:25 AM

Harbormaster completed remote builds in B17525: Diff 23993.Mar 22 2023, 6:39 AM

• kuba requested review of this revision.Mar 22 2023, 6:39 AM

ashoat accepted this revision.Mar 22 2023, 3:25 PM

ashoat added inline comments.

keyserver/src/responders/message-responders.js
344 ↗	(On Diff #23993)	Nit: this line should be grouped with where it's used, instead of with the `creatorID` check above
357 ↗	(On Diff #23993)	I don't think this comment is adding any value. I would remove it