Page MenuHomePhabricator

[lib] Added method to call edit_message endpoint
ClosedPublic

Authored by kuba on Mar 22 2023, 5:45 AM.
Tags
None
Referenced Files
F1430444: D7139.id24414.diff
Wed, Mar 27, 10:25 PM
F1430443: D7139.id24261.diff
Wed, Mar 27, 10:25 PM
F1430441: D7139.id23986.diff
Wed, Mar 27, 10:25 PM
F1430402: D7139.id.diff
Wed, Mar 27, 10:24 PM
F1430342: D7139.diff
Wed, Mar 27, 10:11 PM
Unknown Object (File)
Fri, Mar 8, 8:21 AM
Unknown Object (File)
Thu, Mar 7, 5:55 AM
Unknown Object (File)
Tue, Mar 5, 11:13 PM
Subscribers

Details

Summary

Added a new method to call edit_message endpoint to send edited messages to the keyserver.

Test Plan

Checked if the app still works. Other tests are in later diffs.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat requested changes to this revision.Mar 22 2023, 3:02 PM
ashoat added inline comments.
lib/actions/message-actions.js
255–257 ↗(On Diff #23986)

Why are you doing all of this with getResultInfo? What does it achieve?

In the future, please explain strange things like this by annotating the diff before sending it for review. You should expect that your reviewer will always request changes when they see unexpected stuff like this, and it will significantly reduce diff churn if you take the time to review your own diff / explain this sort of thing

This revision now requires changes to proceed.Mar 22 2023, 3:02 PM
kuba marked an inline comment as done.

Removed redundant code

ashoat added inline comments.
lib/types/message-types.js
575–576 ↗(On Diff #24261)

Not sure we need all of these type aliases, I would just use SendEditMessageResponse directly (this is the pattern we have in the codebase today)

This revision is now accepted and ready to land.Mar 28 2023, 5:39 AM