Paths

Table of Contentst

Differential D7139

[lib] Added method to call edit_message endpoint
ClosedPublic
Actions

Authored by • kuba on Mar 22 2023, 5:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 9, 9:46 PM

	Unknown Object (File)
	Sat, Dec 7, 11:38 PM

	Unknown Object (File)
	Sat, Dec 7, 11:38 PM

	Unknown Object (File)
	Sat, Dec 7, 11:38 PM

	Unknown Object (File)
	Sat, Dec 7, 11:38 PM

	Unknown Object (File)
	Nov 10 2024, 10:43 PM

	Unknown Object (File)
	Nov 10 2024, 4:30 PM

	Unknown Object (File)
	Nov 10 2024, 2:42 PM

Subscribers

Details

Reviewers

michal
inka
ginsu
ashoat

Commits

rCOMMfbc82ab63831: [lib] Added method to call edit_message endpoint

Summary

Added a new method to call edit_message endpoint to send edited messages to the keyserver.

Test Plan

Checked if the app still works. Other tests are in later diffs.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• kuba created this revision.Mar 22 2023, 5:45 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 22 2023, 5:45 AM

• kuba added a parent revision: D7129: [lib] Added new 'sendEditMessage' action.Mar 22 2023, 5:46 AM

• kuba added a child revision: D7140: [lib] Displaying edited content in a pending thread.Mar 22 2023, 5:53 AM

• kuba edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B17518: Diff 23986.Mar 22 2023, 5:58 AM

• kuba requested review of this revision.Mar 22 2023, 5:58 AM

ashoat requested changes to this revision.Mar 22 2023, 3:02 PM

ashoat added inline comments.

lib/actions/message-actions.js
255–257	Why are you doing all of this with `getResultInfo`? What does it achieve? In the future, please explain strange things like this by annotating the diff before sending it for review. You should expect that your reviewer will always request changes when they see unexpected stuff like this, and it will significantly reduce diff churn if you take the time to review your own diff / explain this sort of thing

This revision now requires changes to proceed.Mar 22 2023, 3:02 PM

Removed redundant code

Harbormaster completed remote builds in B17726: Diff 24261.Mar 28 2023, 1:13 AM

ashoat accepted this revision.Mar 28 2023, 5:39 AM

ashoat added inline comments.

lib/types/message-types.js
575–576 ↗	(On Diff #24261)	Not sure we need all of these type aliases, I would just use `SendEditMessageResponse` directly (this is the pattern we have in the codebase today)

This revision is now accepted and ready to land.Mar 28 2023, 5:39 AM

Closed by commit rCOMMfbc82ab63831: [lib] Added method to call edit_message endpoint (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyMar 30 2023, 7:43 AM

This revision was automatically updated to reflect the committed changes.

kosmydel <kukubaczek@gmail.com> added a commit: rCOMMfbc82ab63831: [lib] Added method to call edit_message endpoint.

Revision Contents
Changeset List

Path

Size

lib/

actions/

message-actions.js

32 lines

types/

message-types.js

1 line

Diff 23986

lib/actions/message-actions.js

Loading...

lib/types/message-types.js

Loading...