[native] Added new editing messages type to MessageSpecs in C++
ClosedPublic
Actions

Authored by kuba on Tue, Mar 7, 1:41 AM.

Details

Reviewers

michal
inka
ginsu
ashoat

Commits

rCOMM29fb3ffd218e: [native] Added new editing messages type to MessageSpecs in C++

Summary

Added new EDIT_MESSAGE message type in C++.

Test Plan

Compiled it on iOS, run the app, check if works.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kuba created this revision.Tue, Mar 7, 1:41 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptTue, Mar 7, 1:41 AM

kuba added a parent revision: D6963: [lib] Added new MessageSpec for editing messages.Tue, Mar 7, 1:42 AM

kuba retitled this revision from x[native] Added new editing messages type to MessageSpecs in C++ to [native] Added new editing messages type to MessageSpecs in C++.

kuba added a child revision: D6965: [lib][native] Displaying edited messages from database.Tue, Mar 7, 1:44 AM

Harbormaster completed remote builds in B17137: Diff 23477.Tue, Mar 7, 1:56 AM

kuba requested review of this revision.Tue, Mar 7, 1:56 AM

kuba added a reviewer: ginsu.Tue, Mar 7, 8:11 AM

Not an expert in C++ but your code follows the pattern I used when writing the C++ message spec for reactions. Would be helpful to get a second pair of eyes here

This revision is now accepted and ready to land.Thu, Mar 9, 10:25 AM

ashoat accepted this revision.Thu, Mar 9, 11:43 AM

Closed by commit rCOMM29fb3ffd218e: [native] Added new editing messages type to MessageSpecs in C++ (authored by kosmydel <kukubaczek@gmail.com>). · Explain WhyThu, Mar 30, 7:23 AM

This revision was automatically updated to reflect the committed changes.

kosmydel <kukubaczek@gmail.com> added a commit: rCOMM29fb3ffd218e: [native] Added new editing messages type to MessageSpecs in C++.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

PersistentStorageUtilities/

MessageOperationsUtilities/

MessageSpecs.h

4 lines

MessageSpecs/

EditMessageSpec.h

15 lines

Diff 24396

View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/MessageOperationsUtilities/MessageSpecs.h