Page MenuHomePhabricator

[native] Added new editing messages type to MessageSpecs in C++
ClosedPublic

Authored by kuba on Mar 7 2023, 1:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 6, 7:16 AM
Unknown Object (File)
Thu, Mar 28, 1:05 AM
Unknown Object (File)
Thu, Mar 28, 1:05 AM
Unknown Object (File)
Thu, Mar 28, 1:04 AM
Unknown Object (File)
Thu, Mar 28, 12:55 AM
Unknown Object (File)
Feb 21 2024, 4:04 AM
Unknown Object (File)
Feb 20 2024, 10:12 PM
Unknown Object (File)
Feb 20 2024, 10:11 PM
Subscribers

Details

Summary

Added new EDIT_MESSAGE message type in C++.

Test Plan

Compiled it on iOS, run the app, check if works.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kuba retitled this revision from x[native] Added new editing messages type to MessageSpecs in C++ to [native] Added new editing messages type to MessageSpecs in C++.

Not an expert in C++ but your code follows the pattern I used when writing the C++ message spec for reactions. Would be helpful to get a second pair of eyes here

This revision is now accepted and ready to land.Mar 9 2023, 10:25 AM