[native] Move 'InlineEngagement' styling from 'ComposedMessage' to component
ClosedPublic
Actions

Authored by • kuba on Mar 14 2023, 1:38 AM.

Details

Reviewers

michal
inka
ginsu

Commits

rCOMM9258e1a4b5bf: [native] Move 'InlineEngagement' styling from 'ComposedMessage' to component

Summary

Move 'InlineEngagement' styling from 'ComposedMessage' to 'InlineEngagement' component to make it concise with the web version. It makes it also easier to add message labels to the code, so they were in the 'InlineEngagement' component, like on the web.

Test Plan

Checked if everything works after the changes. Nothing visible should change. Compared how reactions and threads are rendered in iOS and Android simulators with the old
version.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• kuba created this revision.Mar 14 2023, 1:38 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 14 2023, 1:38 AM

• kuba added a parent revision: D7018: [web] Displaying 'Edit' label next to edited messages.Mar 14 2023, 1:38 AM

• kuba added a child revision: D7065: [native] Added displaying labels to InlineEngagement.Mar 14 2023, 1:52 AM

Harbormaster completed remote builds in B17309: Diff 23708.Mar 14 2023, 1:53 AM

• kuba requested review of this revision.Mar 14 2023, 1:53 AM

Rebase

Harbormaster completed remote builds in B17582: Diff 24070.Mar 24 2023, 5:47 AM

inka added inline comments.Mar 28 2023, 7:19 AM

native/chat/inline-engagement.react.js
125–132 ↗	(On Diff #24070)	Why can't this be inlined in line 146? Is this memo necessary?

• kuba added inline comments.Mar 28 2023, 8:56 AM

native/chat/inline-engagement.react.js
125–132 ↗	(On Diff #24070)	Here it probably could be inlined. But I prepared it for the next diff: https://phab.comm.dev/D7065 (which still requires some changes, which will partly answer this question).