Page MenuHomePhabricator
Differential D8903

[native] Show chats in mention typeahead tooltip
AbandonedPublicDraft
Actions

Authored by • patryk on Aug 22 2023, 2:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 18, 10:32 AM
Unknown Object (File)
Thu, Apr 17, 2:49 PM
Unknown Object (File)
Wed, Apr 16, 8:50 AM
Unknown Object (File)
Wed, Apr 9, 12:57 AM
Unknown Object (File)
Wed, Apr 9, 12:06 AM
Unknown Object (File)
Tue, Apr 8, 11:09 PM
Unknown Object (File)
Mar 17 2025, 3:22 AM
Unknown Object (File)
Mar 17 2025, 3:21 AM
View All 61 Files
Subscribers
ashoat
tomek

Details

Reviewers
None
Summary

T

Test Plan

T

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
29 lines
native/
avatars/
8 lines
chat/
62 lines
utils/
3 lines

Diff 30187

View Options

lib/shared/mention-utils.js

Show All 19 Linesimport {
getMostRecentNonLocalMessageID, getMostRecentNonLocalMessageID,
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesfunction useCreateChatThreadItem(): ThreadInfo => ChatThreadItem {
const getLastUpdatedTimes = useGetLastUpdatedTimes(); const getLastUpdatedTimes = useGetLastUpdatedTimes();
return React.useCallback( return React.useCallback(
threadInfo => { threadInfo => {
const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID( const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID(
threadInfo.id, threadInfo.id,
messageStore, messageStore,
); );
const { lastUpdatedAtLeastTime: lastUpdatedTime } = getLastUpdatedTimes( const { lastUpdatedAtLeastTime } = getLastUpdatedTimes(
threadInfo, threadInfo,
messageStore, messageStore,
messageInfos, messageInfos,
); );
const sidebars = sidebarInfos[threadInfo.id] ?? []; const sidebars = sidebarInfos[threadInfo.id] ?? [];
const allSidebarItems = sidebars.map(sidebarInfo => ({ const lastUpdatedAtLeastTimeIncludingSidebars =
type: 'sidebar', sidebars.length > 0
...sidebarInfo, ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
})); : lastUpdatedAtLeastTime;
const lastUpdatedTimeIncludingSidebars =
allSidebarItems.length > 0
? Math.max(lastUpdatedTime, allSidebarItems[0].lastUpdatedTime)
: lastUpdatedTime;
const sidebarItems = getSidebarItems(allSidebarItems); const allInitialSidebarItems = getAllInitialSidebarItems(sidebars);
const sidebarItems = getSidebarItems(allInitialSidebarItems);
return { return {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
lastUpdatedTime, lastUpdatedTime: lastUpdatedAtLeastTime,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars:
lastUpdatedAtLeastTimeIncludingSidebars,
sidebars: sidebarItems, sidebars: sidebarItems,
}; };
}, },
[messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes], [messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes],
); );
} }
function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> { function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> {
▲ Show 20 Lines • Show All 488 Lines • Show Last 20 Lines
View Options

native/avatars/thread-avatar.react.js

Show All 19 Linesimport {
getMostRecentNonLocalMessageID, getMostRecentNonLocalMessageID,
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesfunction useCreateChatThreadItem(): ThreadInfo => ChatThreadItem {
const getLastUpdatedTimes = useGetLastUpdatedTimes(); const getLastUpdatedTimes = useGetLastUpdatedTimes();
return React.useCallback( return React.useCallback(
threadInfo => { threadInfo => {
const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID( const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID(
threadInfo.id, threadInfo.id,
messageStore, messageStore,
); );
const { lastUpdatedAtLeastTime: lastUpdatedTime } = getLastUpdatedTimes( const { lastUpdatedAtLeastTime } = getLastUpdatedTimes(
threadInfo, threadInfo,
messageStore, messageStore,
messageInfos, messageInfos,
); );
const sidebars = sidebarInfos[threadInfo.id] ?? []; const sidebars = sidebarInfos[threadInfo.id] ?? [];
const allSidebarItems = sidebars.map(sidebarInfo => ({ const lastUpdatedAtLeastTimeIncludingSidebars =
type: 'sidebar', sidebars.length > 0
...sidebarInfo, ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
})); : lastUpdatedAtLeastTime;
const lastUpdatedTimeIncludingSidebars =
allSidebarItems.length > 0
? Math.max(lastUpdatedTime, allSidebarItems[0].lastUpdatedTime)
: lastUpdatedTime;
const sidebarItems = getSidebarItems(allSidebarItems); const allInitialSidebarItems = getAllInitialSidebarItems(sidebars);
const sidebarItems = getSidebarItems(allInitialSidebarItems);
return { return {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
lastUpdatedTime, lastUpdatedTime: lastUpdatedAtLeastTime,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars:
lastUpdatedAtLeastTimeIncludingSidebars,
sidebars: sidebarItems, sidebars: sidebarItems,
}; };
}, },
[messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes], [messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes],
); );
} }
function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> { function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> {
▲ Show 20 Lines • Show All 488 Lines • Show Last 20 Lines
View Options

native/chat/chat-input-bar.react.js

Show All 19 Linesimport {
getMostRecentNonLocalMessageID, getMostRecentNonLocalMessageID,
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesfunction useCreateChatThreadItem(): ThreadInfo => ChatThreadItem {
const getLastUpdatedTimes = useGetLastUpdatedTimes(); const getLastUpdatedTimes = useGetLastUpdatedTimes();
return React.useCallback( return React.useCallback(
threadInfo => { threadInfo => {
const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID( const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID(
threadInfo.id, threadInfo.id,
messageStore, messageStore,
); );
const { lastUpdatedAtLeastTime: lastUpdatedTime } = getLastUpdatedTimes( const { lastUpdatedAtLeastTime } = getLastUpdatedTimes(
threadInfo, threadInfo,
messageStore, messageStore,
messageInfos, messageInfos,
); );
const sidebars = sidebarInfos[threadInfo.id] ?? []; const sidebars = sidebarInfos[threadInfo.id] ?? [];
const allSidebarItems = sidebars.map(sidebarInfo => ({ const lastUpdatedAtLeastTimeIncludingSidebars =
type: 'sidebar', sidebars.length > 0
...sidebarInfo, ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
})); : lastUpdatedAtLeastTime;
const lastUpdatedTimeIncludingSidebars =
allSidebarItems.length > 0
? Math.max(lastUpdatedTime, allSidebarItems[0].lastUpdatedTime)
: lastUpdatedTime;
const sidebarItems = getSidebarItems(allSidebarItems); const allInitialSidebarItems = getAllInitialSidebarItems(sidebars);
const sidebarItems = getSidebarItems(allInitialSidebarItems);
return { return {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
lastUpdatedTime, lastUpdatedTime: lastUpdatedAtLeastTime,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars:
lastUpdatedAtLeastTimeIncludingSidebars,
sidebars: sidebarItems, sidebars: sidebarItems,
}; };
}, },
[messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes], [messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes],
); );
} }
function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> { function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> {
▲ Show 20 Lines • Show All 488 Lines • Show Last 20 Lines
View Options

native/utils/typeahead-utils.js

Show All 19 Linesimport {
getMostRecentNonLocalMessageID, getMostRecentNonLocalMessageID,
messageKey, messageKey,
robotextForMessageInfo, robotextForMessageInfo,
sortMessageInfoList, sortMessageInfoList,
} from '../shared/message-utils.js'; } from '../shared/message-utils.js';
import { messageSpecs } from '../shared/messages/message-specs.js'; import { messageSpecs } from '../shared/messages/message-specs.js';
import { import {
getSidebarItems, getSidebarItems,
getAllInitialSidebarItems,
type SidebarItem, type SidebarItem,
} from '../shared/sidebar-item-utils.js'; } from '../shared/sidebar-item-utils.js';
import { threadInChatList, threadIsPending } from '../shared/thread-utils.js'; import { threadInChatList, threadIsPending } from '../shared/thread-utils.js';
import { messageTypes } from '../types/message-types-enum.js'; import { messageTypes } from '../types/message-types-enum.js';
import { import {
type ComposableMessageInfo, type ComposableMessageInfo,
isComposableMessageType, isComposableMessageType,
type LocalMessageInfo, type LocalMessageInfo,
▲ Show 20 Lines • Show All 51 Lines • ▼ Show 20 Linesfunction useCreateChatThreadItem(): ThreadInfo => ChatThreadItem {
const getLastUpdatedTimes = useGetLastUpdatedTimes(); const getLastUpdatedTimes = useGetLastUpdatedTimes();
return React.useCallback( return React.useCallback(
threadInfo => { threadInfo => {
const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID( const mostRecentNonLocalMessage = getMostRecentNonLocalMessageID(
threadInfo.id, threadInfo.id,
messageStore, messageStore,
); );
const { lastUpdatedAtLeastTime: lastUpdatedTime } = getLastUpdatedTimes( const { lastUpdatedAtLeastTime } = getLastUpdatedTimes(
threadInfo, threadInfo,
messageStore, messageStore,
messageInfos, messageInfos,
); );
const sidebars = sidebarInfos[threadInfo.id] ?? []; const sidebars = sidebarInfos[threadInfo.id] ?? [];
const allSidebarItems = sidebars.map(sidebarInfo => ({ const lastUpdatedAtLeastTimeIncludingSidebars =
type: 'sidebar', sidebars.length > 0
...sidebarInfo, ? Math.max(lastUpdatedAtLeastTime, sidebars[0].lastUpdatedAtLeastTime)
})); : lastUpdatedAtLeastTime;
const lastUpdatedTimeIncludingSidebars =
allSidebarItems.length > 0
? Math.max(lastUpdatedTime, allSidebarItems[0].lastUpdatedTime)
: lastUpdatedTime;
const sidebarItems = getSidebarItems(allSidebarItems); const allInitialSidebarItems = getAllInitialSidebarItems(sidebars);
const sidebarItems = getSidebarItems(allInitialSidebarItems);
return { return {
type: 'chatThreadItem', type: 'chatThreadItem',
threadInfo, threadInfo,
mostRecentNonLocalMessage, mostRecentNonLocalMessage,
lastUpdatedTime, lastUpdatedTime: lastUpdatedAtLeastTime,
lastUpdatedTimeIncludingSidebars, lastUpdatedTimeIncludingSidebars:
lastUpdatedAtLeastTimeIncludingSidebars,
sidebars: sidebarItems, sidebars: sidebarItems,
}; };
}, },
[messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes], [messageInfos, messageStore, sidebarInfos, getLastUpdatedTimes],
); );
} }
function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> { function useFlattenedChatListData(): $ReadOnlyArray<ChatThreadItem> {
▲ Show 20 Lines • Show All 488 Lines • Show Last 20 Lines