Page MenuHomePhabricator

[keyserver] Update deleters to look at new user_container column
ClosedPublic

Authored by ashoat on May 10 2024, 8:43 AM.
Tags
None
Referenced Files
F3365165: D11989.id40113.diff
Mon, Nov 25, 6:53 AM
Unknown Object (File)
Sun, Nov 24, 9:57 PM
Unknown Object (File)
Sun, Nov 24, 1:35 PM
Unknown Object (File)
Fri, Nov 22, 1:35 PM
Unknown Object (File)
Fri, Nov 22, 7:32 AM
Unknown Object (File)
Thu, Nov 21, 2:21 AM
Unknown Object (File)
Thu, Nov 21, 2:20 AM
Unknown Object (File)
Oct 26 2024, 1:11 PM
Subscribers
None

Details

Summary

This diff updates the keyserver code for several deleters:

  1. For deleting an upload, we'll check to make sure it's not assigned to a user
  2. For deleting unassigned uploads, we'll check to make sure they're not assigned to a user
  3. For deleting an account, we'll make sure to delete any corresponding avatar upload

Depends on D11988

Test Plan

I tested the whole stack with the following steps:

  1. Ran the migration on a backup of my production keyserver database from September 2023. Confirm that the uploads table has the new column, that it has an index, and that it's populated for all cases where the old column matched a user. Confirm that only 32 rows were updated, which matched the number of users with avatars in a prior query
  2. Create a brand new database. Confirm that the Confirm that the uploads table has the new column, and that it has an index. Make sure DESCRIBE uploads; matches what it looked like in step 1
  3. Run the migration on my local multi-keyserver testing database. Make sure I'm still able to log in with an existing user. Confirm I can change the existing user's avatar to a photo and that there are no errors in the logs. Confirm that the avatar is still there if I log out and back in
  4. On the same database, try creating a new user with a photo avatar and confirm that it works, and that there are no errors in the logs. Confirm that the avatar is still there if I log out and back in
  5. Ran git grep container in the keyserver folder and reviewed every result to consider whether it needs to be updated

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage