[lib][native][web] Introduce useUpdateRelationships
ClosedPublic
Actions

Authored by ashoat on Sep 23 2024, 10:40 PM.

Details

Reviewers

tomek

Commits

rCOMMbf4c664c5951: [lib][native][web] Introduce useUpdateRelationships

Summary

This diff updates the updateRelationships action function to use the new update_relationships2 API, and introduces useUpdateRelationships, a new hook that abstracts some complexity and in following diffs will handle forking between thick/thread logic.

Depends on D13440

Test Plan

I tested this new endpoint as part of my testing of ENG-9269

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Sep 23 2024, 10:40 PM

ashoat added a child revision: D13443: [lib] Add support to useUpdateRelationships for sending relationship robotext to thick threads.Sep 23 2024, 10:42 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 23 2024, 10:54 PM

Harbormaster failed remote builds in B31798: Diff 44464!

Rebase

Harbormaster completed remote builds in B31809: Diff 44475.Sep 24 2024, 12:08 AM

ashoat requested review of this revision.Sep 24 2024, 12:08 AM

tomek accepted this revision.Sep 24 2024, 3:31 AM

tomek added inline comments.

lib/components/farcaster-data-handler.react.js
47	Does the new endpoint correctly support `farcaster` action without `userIDsToFID` map?

This revision is now accepted and ready to land.Sep 24 2024, 3:31 AM

ashoat added inline comments.Sep 24 2024, 10:13 AM

lib/components/farcaster-data-handler.react.js
47	D13436 updates our code to ignore this input from the user. Instead of trusting the user's claims about FIDs, we will instead query the identity service