HomePhabricator
Diffusion Comm 040e1b7f2f9c

[services] Backup - client reactors - distinguish terminated from done

Description

[services] Backup - client reactors - distinguish terminated from done

Summary:
Depends on D3664

We need to separate two pieces of information: when the reactor is terminated and when it is "done".

  • terminated - this means that there are no more operations defined by the user
  • done - this means that there will be no more gRPC operations performed for this reactor (all of 'em are done)

Thing is, gRPC does some finalizing operations after we terminate a reactor.

Test Plan:

cd services
yarn run-backup-service

Reviewers: palys-swm

Reviewed By: palys-swm

Subscribers: ashoat, palys-swm, Adrian, atul, benschac, yayabosh

Differential Revision: https://phabricator.ashoat.com/D3719

Details

Provenance
karolAuthored on Apr 13 2022, 7:22 AM
Reviewer
tomek
Differential Revision
D3719: [services] Backup - client reactors - distinguish terminated from done
Parents
rCOMM61665dd80d82: [services] Backup/Blob - Make sure Finish is only called once
Branches
Unknown
Tags
Unknown