HomePhabricator
Diffusion Comm 0856ba174897

[native] Displaying edit mode

Tags
None
Referenced Files
F493264: Screenshot 2023-04-18 at 12.34.36.png
Apr 25 2023, 6:44 AM
File Not Attached
F468150: Screenshot 2023-04-07 at 16.15.06.png
Apr 25 2023, 6:44 AM
File Not Attached
F468149: Screenshot 2023-04-07 at 16.14.31.png
Apr 25 2023, 6:44 AM
File Not Attached
F468148: Screenshot 2023-04-07 at 16.13.38.png
Apr 25 2023, 6:44 AM
File Not Attached
F468147: Screenshot 2023-04-07 at 16.13.04.png
Apr 25 2023, 6:44 AM
File Not Attached
F468146: Screenshot 2023-04-07 at 16.12.23.png
Apr 25 2023, 6:44 AM
File Not Attached
Subscribers
None

Description

[native] Displaying edit mode

Summary: Added displaying edit GUI when in edit mode.

Test Plan:
Checked if after clicking 'Edit' on the target message edit mode is turned on.
Checked if the displayed content of the edited message work in different situations:

  • if the original message is already edited,
  • if the original message has some markdown,
  • if the original message is really long/multiline,
  • if the original message has replies/quotes,

Screenshot 2023-04-07 at 16.12.23.png (308×770 px, 83 KB)

Screenshot 2023-04-07 at 16.13.04.png (276×754 px, 65 KB)

Screenshot 2023-04-07 at 16.13.38.png (370×774 px, 87 KB)

Screenshot 2023-04-07 at 16.14.31.png (368×764 px, 109 KB)

With already edited content:

Screenshot 2023-04-07 at 16.15.06.png (326×742 px, 59 KB)

On Android:

Screenshot 2023-04-18 at 12.34.36.png (492×664 px, 87 KB)

Reviewers: michal, inka, ginsu, tomek

Reviewed By: tomek

Subscribers: ashoat, tomek, atul

Differential Revision: https://phab.comm.dev/D7344

Details

Provenance
kosmydel <kukubaczek@gmail.com>Authored on Apr 6 2023, 7:40 AM
Reviewer
tomek
Differential Revision
D7344: [native] Displaying edit mode
Parents
rCOMMe5cd32b03032: [native] Change EditState to store messageInfo instead of only id
Branches
Unknown
Tags
Unknown

Event Timeline