HomePhabricator
Diffusion Comm 0abf9b063af3

[desktop] Navigation arrows

Description

[desktop] Navigation arrows

Summary:
Show navigation arrows for desktop and enable/ disable them depending on history.

  • dekstop/preload.js is running on the renderer thread (as opposed to desktop/main.js which runs on the "browser" thread) and it's often used for communication between web app and system apis. The communication between threads is achieved using IPC.
  • web/electron.js types the objects exposed in preload.js

Test Plan:

  • Check if the navigation arrows are working correctly on the desktop, e.g. check that if you are in a middle of the stack and you click somewhere else the top of the stack is replaced.
  • Check if there are no changes to the web app

Reviewers: tomek, atul, abosh, kamil, ashoat

Reviewed By: tomek, atul, ashoat

Subscribers: kamil, ashoat

Differential Revision: https://phab.comm.dev/D5630

Details

Provenance
Michal Gniadek <michal.gniadek@swmansion.com>Authored on Nov 14 2022, 8:26 AM
Reviewer
tomek
Differential Revision
D5630: [desktop] Navigation arrows
Parents
rCOMM3b80dea6799f: [desktop] Basic electron app
Branches
Unknown
Tags
Unknown

Event Timeline

Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM0abf9b063af3: [desktop] Navigation arrows (authored by Michal Gniadek <michal.gniadek@swmansion.com>).Nov 23 2022, 6:08 AM