HomePhabricator
Diffusion Comm 10d59f3d5dbb

[native] Fix appearance of Inbox header in light mode

Tags
None
Referenced Files
F232291: 782509.png
Nov 11 2022, 1:08 PM
File Not Attached
F232290: 692c87.png
Nov 11 2022, 1:08 PM
File Not Attached
Subscribers
None

Description

[native] Fix appearance of Inbox header in light mode

Summary:
Context: https://linear.app/comm/issue/ENG-1395/inbox-header-remains-dark-in-light-mode
https://linear.app/comm/issue/ENG-2052/re-introduce-light-mode-in-native

The backgroundColor of the Inbox header was previously hardcoded to a dark value that looked fine in dark mode but looked broken in light mode.

This diff sets the backgroundColor to tabBarBackground which will adapt based on the theme.

Test Plan:
Before:

692c87.png (1×714 px, 312 KB)

After:

782509.png (1×716 px, 309 KB)

Things looks as expected.

Reviewers: tomek, marcin, ginsu, rohan, abosh, varun, O2 Blocking Reviewers, ashoat

Reviewed By: ginsu, rohan, O2 Blocking Reviewers, ashoat

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D5610

Details

Provenance
atulAuthored on Nov 10 2022, 5:08 PM
Reviewer
Restricted Owners Package
Differential Revision
D5610: [native] Fix appearance of Inbox header in light mode
Parents
rCOMM1bd75cdc4161: [services] Get rid of `return std::move(...)` in services codebase
Branches
Unknown
Tags
Unknown