HomePhabricator
Diffusion Comm 21ffa9c4b1f2

[1/2][CommCoreModule] Add option to close network module

Description

[1/2][CommCoreModule] Add option to close network module

Summary: The best way to close a grpc connection is to call a destructor of the client and to do that we just need to reset the pointer to our network Client.

Test Plan: It's hard to test it well now as we're not initializing the connection yet, so the proper testing will be performed later. For now checking if the app can be run should be enough.

Reviewers: karol-bisztyga, ashoat

Reviewed By: karol-bisztyga, ashoat

Subscribers: ashoat, Adrian, atul, benschac, boristopalov

Differential Revision: https://phabricator.ashoat.com/D2540

Details

Provenance
tomekAuthored on Dec 2 2021, 3:05 AM
Reviewer
karol
Differential Revision
Restricted Differential Revision
Parents
rCOMM5108b7b1a24f: [4/n] [services] Run all services with one command
Branches
Unknown
Tags
Unknown