HomePhabricator
Diffusion Comm 37e15109c0cf

[backup service] Revoke log blob holders

Description

[backup service] Revoke log blob holders

Summary:
My mistake - forgot to add this code to the backup service while adding logs. This diff adds the code to call blob service revoke holder after removing a log. It also improves the holder revoke for backups a bit so that the blob is called inside of the remove_backup_item function and not in the http handler.

Depends on D11142

Test Plan:

  • Create a new backup with logs
  • Make sure that the log is stored in blob service (and not inline in dynamodb)
  • Check that the log blob has a holder
  • Delete the backup
  • Check the the log blob no longer has a holder

Reviewers: bartek, kamil

Reviewed By: kamil

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D11143

Details

Provenance
Michal Gniadek <michal.gniadek@swmansion.com>Authored on Feb 22 2024, 3:47 AM
Reviewer
kamil
Differential Revision
D11143: [backup service] Revoke log blob holders
Parents
rCOMM26da9472d3f2: [web] Add backup testing screen
Branches
Unknown
Tags
Unknown

Event Timeline

Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM37e15109c0cf: [backup service] Revoke log blob holders (authored by Michal Gniadek <michal.gniadek@swmansion.com>).Mar 6 2024, 6:13 AM