HomePhabricator
Diffusion Comm 4d5b4f6c049a

[services] Fix warnings

Description

[services] Fix warnings

Summary:
Fixes two small warnings:

  • unused import
  • deprecation of from_utc -> replaced with from_naive_utc_and_offset

The second one is a bit tricker because the deprecation notice was introduced in a patch version, and our services used two different versions of the library. The newer version had the deprecation notice. But we can't just update all the callsites because the older version doesn't have the replacement function. Because of that I also pinned this library in all of our dependencies to the newer patch version.

Depends on D10256

Test Plan: Check if services compile.

Reviewers: bartek, varun, kamil

Reviewed By: bartek

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D10257

Details

Provenance
Michal Gniadek <michal.gniadek@swmansion.com>Authored on Dec 4 2023, 3:47 AM
Reviewer
bartek
Differential Revision
D10257: [services] Fix warnings
Parents
rCOMM1eb7831cc2e2: [service] Move services lib to shared
Branches
Unknown
Tags
Unknown

Event Timeline

Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM4d5b4f6c049a: [services] Fix warnings (authored by Michal Gniadek <michal.gniadek@swmansion.com>).Dec 19 2023, 7:29 AM