HomePhabricator
Diffusion Comm 58b491f3f390

[server] [fix] Unify permissions for `OPEN_SUBTHREAD` and `SECRET_SUBTHREAD`

Description

[server] [fix] Unify permissions for OPEN_SUBTHREAD and SECRET_SUBTHREAD

Summary:
Unify permissions for community OPEN and SECRET subthread to solve the issue:
https://linear.app/comm/issue/ENG-1004/error-when-adding-user-that-is-not-in-parent-thread-to-open-subchannel

The diff requires database migration to fix permissions in already existing threads. It will be introduced in follow-up diff.

Test Plan:
Create new Open thread nested in Secret thread - the issue described in ENG-1004 should no longer exist.
Users not in parent thread can now be added to child thread. Tested in mobile and web app.
After database migration the issue should also disappear in all already existing threads.

Reviewers: palys-swm, ashoat

Reviewed By: ashoat

Subscribers: Adrian, atul, yayabosh

Differential Revision: https://phab.comm.dev/D4069

Details

Provenance
jacekAuthored on Jul 15 2022, 1:54 AM
Reviewer
ashoat
Differential Revision
D4069: [server] [fix] Unify permissions for `OPEN_SUBTHREAD` and `SECRET_SUBTHREAD`
Parents
rCOMMc2ddd80af740: [keyserver] Revert D4422 and D4429
Branches
Unknown
Tags
Unknown