HomePhabricator
Diffusion Comm 6f4a1fb736a6

[native] Fix long names intersecting with the search button

Description

[native] Fix long names intersecting with the search button

Summary:
issue: https://linear.app/comm/issue/ENG-3925/long-names-intersecting-with-search-button
from documentation (https://reactnavigation.org/docs/3.x/stack-navigator/#headertitlecontainerstyle):

By default, headerTitleContainerStyle is with an absolute position style and offsets both left and right. This may lead to white space or overlap between headerLeft and headerTitle if a customized headerLeft is used. It can be solved by adjusting left and right style in headerTitleContainerStyle and marginHorizontal in headerTitleStyle.

Our problem was with the headerRight, but an analogical solution worked

Test Plan:

Simulator Screenshot - iPhone 14 Pro - 2023-06-05 at 09.10.30.png (2×1 px, 252 KB)

When there are no buttons:

Simulator Screenshot - iPhone 14 Pro - 2023-06-05 at 09.07.33.png (2×1 px, 342 KB)

On android long names were always cut pretty short. Before my changes:

Screenshot_20230605_095025.png (2×1 px, 209 KB)

After my changes:

Screenshot_20230605_094533.png (2×1 px, 210 KB)

Reviewers: tomek, atul, ginsu

Reviewed By: tomek

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D8091

Details

Provenance
InkaSokolowskaAuthored on Jun 5 2023, 5:29 AM
Reviewer
tomek
Differential Revision
D8091: [native] Fix long names intersecting with the search button
Parents
rCOMM827723074c39: [identity] db methods for reserved usernames table
Branches
Unknown
Tags
Unknown