HomePhabricator
Diffusion Comm 7a5905cdb914

[native] Fix android bottom navigation bar ovelapping with drawer content

Tags
None
Referenced Files
F313336: android_bottom_bar_4.png
Jan 2 2023, 6:25 AM
File Not Attached
F313335: android_bottom_bar_2.jpg
Jan 2 2023, 6:25 AM
File Not Attached
Subscribers
None

Description

[native] Fix android bottom navigation bar ovelapping with drawer content

Summary:
Linear issue: https://linear.app/comm/issue/ENG-2603/community-drawer-safeareaview
I was doing some additional testing on physical devices, and I noticed that the androids bottom navigation bar was covering some of the drawer content if the drawer content took up all drawer height. This fixes that, and here is what it looks like now with and without the bottom bar on android:

android_bottom_bar_2.jpg (2×1 px, 218 KB)

android_bottom_bar_4.png (2×1 px, 148 KB)

It has been decided in ENG-2343 that we don't want to use 'bottom' option of SafeAreaView for iOS devices, so iOS stayed the same.

Test Plan:
Tested on two android physical devices, iOS simulator, iOS physical device. Checked that the drawer content doesn't overlap with androids navigation bar, and looks right when the bar is not present
(gestures enabled), and looks right on iOS.

Reviewers: tomek, bartek, ginsu

Reviewed By: tomek

Subscribers: ashoat, atul

Differential Revision: https://phab.comm.dev/D6137