HomePhabricator
Diffusion Comm 7db46114630b

[web] Fix `ThreadSettingsGeneralTab` save button `disabled` prop

Tags
None
Referenced Files
F53313: Screen Recording 2022-05-09 at 9.52.07 PM.mov
May 20 2022, 11:53 AM
F53312: Screen Recording 2022-05-06 at 12.38.15 AM.mov
May 20 2022, 11:53 AM
Subscribers
None

Description

[web] Fix ThreadSettingsGeneralTab save button disabled prop

Summary:
Fixed the save button in ThreadSettingsGeneralTab which was previously not staying disabled if the user had selected another color and then changed their selection back to the current thread color (making no other changes in the thread settings) (see before/after video in Test Plan).

Related Linear issue with full context here.

Test Plan:
Tested on Chrome/Safari and works as expected.

Before:

After:

Reviewers: atul, palys-swm, ashoat

Reviewed By: atul, ashoat

Subscribers: ashoat, palys-swm, Adrian

Differential Revision: https://phabricator.ashoat.com/D3980

Details

Provenance
aboshAuthored on May 9 2022, 9:44 PM
Reviewer
atul
Differential Revision
D3980: [web] Fix `ThreadSettingsGeneralTab` save button `disabled` prop
Parents
rCOMMc85b3e51a769: [CI] Potentially improve reliability of Android CI
Branches
Unknown
Tags
Unknown