HomePhabricator
Diffusion Comm 9bfd7a1c01b9

[web] Introduce plain Button variant

Description

[web] Introduce plain Button variant

Summary:
Part of ENG-843
Introduces plain Button variant with minimal css properties. It becomes the default variant, so this diff also changes any Buttons without explicit variant to use filled.

Also makes the onClick nullable and sets the type to button to make it more general.

This variant is used in a later diff.

Test Plan:

  • Run flow
  • Check if all changed buttons look and work the same
  • Check if there is any <form> that uses a Button without an explicit type set

Reviewers: tomek, atul, abosh, ginsu

Reviewed By: tomek, atul, ginsu

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D5342

Details

Provenance
Michal Gniadek <michal.gniadek@swmansion.com>Authored on Oct 11 2022, 5:20 AM
Reviewer
tomek
Differential Revision
D5342: [web] Introduce plain Button variant
Parents
rCOMM824b816c8a1b: [web] Use <a> instead of <div> in some places
Branches
Unknown
Tags
Unknown

Event Timeline

Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM9bfd7a1c01b9: [web] Introduce plain Button variant (authored by Michal Gniadek <michal.gniadek@swmansion.com>).Oct 20 2022, 8:55 AM