HomePhabricator
Diffusion Comm 9dbbedf7d7e4

[web] Use Button for text buttons

Tags
None
Referenced Files
F196401: image.png
Oct 20 2022, 8:55 AM
File Not Attached
F196402: image.png
Oct 20 2022, 8:55 AM
File Not Attached
Subscribers
None

Description

[web] Use Button for text buttons

Summary:
Part of ENG-843
Adds a new 'text' variant to Button and uses it instead of plain html elements in:

  • settings screen
  • retry send button
  • user list in thread composer

to keep the web app more consistent.

This diff also fixes visual bugs with retry message:
Before:

image.png (124×322 px, 13 KB)

After:

image.png (130×502 px, 15 KB)

Test Plan:
Check if

  • settings screen
  • retry send button
  • user list in thread composer

look and work correctly.

Reviewers: tomek, atul, abosh, ginsu

Reviewed By: atul, ginsu

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D5322

Details

Provenance
Michal Gniadek <michal.gniadek@swmansion.com>Authored on Oct 4 2022, 1:27 AM
Reviewer
atul
Differential Revision
D5322: [web] Use Button for text buttons
Parents
rCOMM305c6a1ccaea: [web] Separate color in Button
Branches
Unknown
Tags
Unknown

Event Timeline

Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM9dbbedf7d7e4: [web] Use Button for text buttons (authored by Michal Gniadek <michal.gniadek@swmansion.com>).Oct 20 2022, 8:54 AM